feat: add malicious deeplinks, bypasses and reorg #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seaona
commented
Apr 25, 2024
| @@ -3069,65 +3102,6 @@ const initializeFormElements = () => { | |||
| } | |||
| }; | |||
|
|
|||
| /** | |||
| * Send With Odd Hex Data | |||
There was a problem hiding this comment.
this piece just moved to the new ppom section
seaona
commented
Apr 25, 2024
|
|
||
| const handleNewChain = (chainId) => { | ||
| chainIdDiv.innerHTML = chainId; | ||
| const networkId = parseInt(networkDiv.innerHTML, 10); | ||
| chainIdInt = parseInt(chainIdDiv.innerHTML, 16) || networkId; | ||
| chainIdPadded = `0x${chainIdInt.toString(16).padStart(77, '0')}`; |
There was a problem hiding this comment.
we need this new format for the ChainID padded integer bypass
seaona
commented
Apr 25, 2024
| @@ -1636,7 +1669,7 @@ const initializeFormElements = () => { | |||
| params: [ | |||
| { | |||
| from: accounts[0], | |||
| to: '0x5FbDB2315678afecb367f032d93F642f64180aa3', | |||
| to: `${maliciousAddress}`, | |||
There was a problem hiding this comment.
all the malicious address ocurrences have been replaced by the new const variable, for clarity
jpuri
approved these changes
Apr 25, 2024
seaona
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR we add a couple of more functionalities for testing the PPOM feature:
Screenshots
Before
After
malicious-deeplinks-bypasses.mp4
Manual QA Steps