Use current chainId for signTypedData instead of 3
#5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using the `chainId` "3" for the `signTypedData` button (i.e. Ropsten), the test dapp will now use the `chainId` of whichever network is currently selected (falling back to the `networkId` if there is no `chainId`).
jennypollack
pushed a commit
that referenced
this pull request
Apr 1, 2020
Finshed base UI refactor with material design
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using the
chainId"3" for thesignTypedDatabutton (i.e. Ropsten), the test dapp will now use thechainIdof whichever network is currently selected (falling back to thenetworkIdif there is nochainId).This reconciles this repository with the test-dapp in `metamask-extension, which was recently changed: MetaMask/metamask-extension#7859