Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Cast CAIP-2 and CAIP-10 structs to their proper types #210

Merged
merged 1 commit into from
Aug 30, 2024
Merged

fix: Cast CAIP-2 and CAIP-10 structs to their proper types #210

merged 1 commit into from
Aug 30, 2024

Conversation

FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Aug 30, 2024 •
edited
Loading

Fixes a problem with CaipChainIdStruct and CaipAccountIdStruct which were not cast to their respective types and as such were typed as Struct<string, null>. This makes them hard to use when using Describe.

This PR mirrors the implementation from Hex by casting the structs.

@FrederikBolding FrederikBolding requested a review from a team as a code owner August 30, 2024 10:55
@FrederikBolding FrederikBolding merged commit c2048b0 into main Aug 30, 2024
19 checks passed
@FrederikBolding FrederikBolding deleted the fb/cast-caip-structs branch August 30, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mrtenz Mrtenz Mrtenz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FrederikBolding @Mrtenz