WIP: Miniscript final version #764
Conversation
| <Optimize>true</Optimize> | ||
| <DocumentationFile>bin\Release\NBitcoin.TestFramework.XML</DocumentationFile> | ||
| </PropertyGroup> | ||
| </Project> |
There was a problem hiding this comment.
seems some .csproj have unwanted line-ending changes
| select Utils.DictionaryFromList<PubKey, Tuple<HDFingerprint, KeyPath>>(pks.ToList(), fingerPrintAndPath); | ||
| } | ||
| } |
There was a problem hiding this comment.
actually some .cs files too, like this
NBitcoin/NBitcoin.csproj
Outdated
| @@ -20,8 +20,8 @@ | |||
| <EmbedUntrackedSources>true</EmbedUntrackedSources> | |||
| </PropertyGroup> | |||
| <PropertyGroup> | |||
| <TargetFrameworks>net461;net452;netstandard1.3;netstandard1.1;netcoreapp2.1;netstandard2.0</TargetFrameworks> | |||
| result = new PubKey(v); | ||
| return true; | ||
| } | ||
| catch |
There was a problem hiding this comment.
this looks evil, what's the exception type being caught?
There was a problem hiding this comment.
that's why it's evil; when I'm sure the author only intended to capture one type
Spec never fixed until actually somebody use it :p |
|
Can you rebase on master? |
* Pass policy parser tests without using Combinator
joemphilips
force-pushed
the
miniscript_final_version
branch
from
a5dd29b to
b7534c1
Compare
* There are the case which has same serialization format for the script, but we have different ast element representation (e.g. `and_v(X,v:Y)` and `v:and_v(X,Y)`) So the equality criteria for `Terminal<TPk,TPKh>` must be based on its script representation.
| @@ -40,6 +41,8 @@ public PubKey(string hex) | |||
|
|
|||
| } | |||
|
|
|||
| public PubKey() {} | |||
| @@ -0,0 +1,7 @@ | |||
| namespace NBitcoin.Scripting.Descriptor | |||
| { | |||
| public class CreateDescriptor | |||
|
This is an impressive work. What's the plan? |
|
I suspended this PR until the bitcoin-core decides how they treat Miniscript. (i.e. This PR gets merged or this issue get solved) It seems that the author is trying to support taproot in Miniscript before it gets merged. |
NicolasDorier
force-pushed
the
master
branch
from
878114e to
24301c6
Compare
Previous attempt is in #695
Since the spec has changed drastically, I've been re-writing almost everything from scratch 😭
I swear to myself, from next time, I will never start coding until the spec is fixed.