Docker setup #826
Merged
Docker setup #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
launch jenkins |
|
launch jenkins |
|
launch jenkins |
|
launch jenkins |
twicki
suggested changes
Mar 26, 2020
Dockerfile
Outdated
|
|
||
| FROM dawn-gcc9-env AS dawn-gcc9 | ||
| # IMAGE needs be be set to one of the docker/dawn-env.dockerfile images | ||
| ARG IMAGE=gtclang/dawn-env-cuda10.1-ubuntu18.04 |
There was a problem hiding this comment.
if we now have a docker folder, should we put this file also in there (and adapt the path on dockerhub?)
There was a problem hiding this comment.
I'm not sure... Sometimes it's nice to have a top-level Dockerfile that people can immediately build. Something like a Makefile used to be.
There was a problem hiding this comment.
But I'm open to either way! Let me know.
|
launch jenkins |
|
launch jenkins |
|
Everything passes so I'm going to go ahead and merge this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical Description
Use Sarus for containerized tests of Dawn.
To do before merging:
scripts/update-images)sarus pull $imageis the correct usage -- sarus run --pull eth-cscs/sarus#6scripts/jenkins/srun_dawn_PR.shtoscripts/daint-dawn-PRResolves / Enhances
Resolves #623.
Testing
http://localhost:8080/view/PASCHA/job/dawn_gtclang_clang-gridtools_PR/490/