Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Underscore #20

Merged
merged 1 commit into from
Jan 16, 2018
Merged

Remove Underscore #20

merged 1 commit into from
Jan 16, 2018

Conversation

klaussner
Copy link
Contributor

check-npm-versions uses Underscore without explicitly depending on it, which causes the issue described in #18: If no other Meteor package in .meteor/packages depends on Underscore, check-npm-versions throws TypeError: Cannot read property 'forEach' of undefined.

This PR replaces the used Underscore functions (_.forEach and _.keys) with Array.prototype.forEach and Object.keys.

Fixes #18.

@benjamn
Copy link

benjamn commented Jan 16, 2018

@tmeasday How should we proceed here? This is becoming more important since underscore is much more optional in Meteor 1.6.1.

@tmeasday
Copy link
Collaborator

Sorry, I wasn't getting notifications for this repository.

Happy to merge and release; but is someone interested in taking over this repository? I'm not currently using the package and if as @hwillson said it is important infrastructure for the Meteor community, someone who is probably should.

@tmeasday tmeasday merged commit a6b7bc4 into Meteor-Community-Packages:master Jan 16, 2018
@tmeasday
Copy link
Collaborator

@klaussner -- would you like me to add you as a maintainer / give you publish rights?

@tmeasday
Copy link
Collaborator

Published as 0.3.2

@hwillson
Copy link
Collaborator

@tmeasday I'll gladly help maintain this repo is you're interested? Thanks!

@tmeasday
Copy link
Collaborator

tmeasday commented Jan 17, 2018

@hwillson done--and I added you as a maintainer of the package.

@hwillson
Copy link
Collaborator

Awesome - thanks @tmeasday!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants