Add support for async collection methods #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdgjsag67251
changed the title
jdgjsag67251
commented
Aug 28, 2023
StorytellerCZ
requested changes
Aug 29, 2023
There was a problem hiding this comment.
Please use *Async methods when calling DB. Other than that, it looks fine. Much apprectiated!
Once we merge this we should first move to support async functions in hooks and then move the hooks internals to use the new async functions to be ready for Meteor 3.
|
Cool, thnx. I've updated the PR. |
StorytellerCZ
approved these changes
Aug 30, 2023
jankapunkt
approved these changes
Aug 31, 2023
|
That's great @jdgjsag67251 👍 Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #288.
Ok, so apparently Meteor just internally calls the non-async methods and wraps them in a Promise: https://github.com/meteor/meteor/blob/devel/packages/mongo/collection.js#L998.
This PR just adds tests to make sure that the hooks keep working when Meteor changes their implementation.