-
-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Role assign collection #276
Role assign collection #276
Conversation
# Conflicts: # package.js
- no need for updating tests - removed tests for outdated internal behavior - added publication of new collection to test-files
…` = true - Required a lot of changes throughout the tests, which weren't done earlier to make it easy to comprehend that this feature has no BC breaks aside of this - Using `fullObjects` will ignorer the value set in `onlyAssigned`, which required to change some of the tests
In case you've already started with the code-review: I've now made it easier for you to get the full perspective of changes. I split up the changes into one commit, which changes all the internal structuring, where the tests are only minimally changed. In a separate commit I've introduced the only breaking change, which is due to the change of the internal structure. |
The only thing I'm still concerned about is that a call to Other methods (like |
I've now integrated these changes into my codebase, which was a POC and also forced me to change a bit of untested things on the codebase, now covered by tests. In addition I had to do the following in the codebase of my project:
I've also added a migration and rollback script. Please be aware of that a rollback will take significantly longer (10 min migration - rollback 2-3h), so you might be faster (it's a general advice after all) taking a backup of the Any user using the platform during migration will encounter a situation where he is not allowed to do stuff which he actually should be able to. If you need a continuous migration, you'd need to extend the script by hand. Just add a custom property instead of removing the roles and have a second migration-script which removes the roles and this extra property after you've verified that your system is working. This way you would not even need a rollback, but only remove the Hint: When you're using |
This got closed because I renamed |
In addition to my previous PRs, this PR contains a rewrite of the library in which I separated the role-assignments from the user document. This is the first attempt of going into the direction I proposed here: #270
@alanning @mitar what are your ideas on this? It changes the output of only one of the methods and replaces/removes some of the internal methods - otherwise there are no changes to the API, nor to the tests. All tests are passing.
Due to my changes here you need to publish the
role-assignments
yourself. See the client-tests as an example.It still has the ability to move scopes to objects. I thought of also having an object there where the current string could represent the
_id
property, where you can add your stuff to.