Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new 120 bay starport #32

Closed
wants to merge 1 commit into from
Closed

new 120 bay starport #32

wants to merge 1 commit into from

Conversation

outridersol
Copy link
Member

Very basic, but we should now have a decent number of docking ports for all stations.

@outridersol
Copy link
Member Author

I'm going to merge this in if there's no objections?

@shadmar
Copy link

shadmar commented Apr 30, 2013

Not sure, but I get some out of memeory crashes, when I stress test landings.
But could be combination of alot of changes I've done. But it seem to start when I added this, just hold it abit longer.

@outridersol
Copy link
Member Author

Yeah, no problem. I've also had some slightly odd behaviour from it too, although nothing that concrete. I think it may also just be piling a lot onto the engine. I don't think it's ever been load tested quite as heavily.

@shadmar
Copy link

shadmar commented May 1, 2013

Might not be the starport since I still run out of memory. I'll see if cutting all textures to 256x256 makes a difference.

@shadmar
Copy link

shadmar commented May 1, 2013

Ok, that was it, we're adressing more than possible n a 32bit evironment, I suggest maybe cutting textures in half (all models), or atleast as small as possible without killing the good looks. I used 256x256 8bit pngs (using a mass converter) and memory dropped 2+ GB.

@outridersol
Copy link
Member Author

Yeah, that shouldn't be too much of a problem. I haven't made much effort towards efficiency, and I was wondering when the engine would buckle.

@outridersol
Copy link
Member Author

Yeah, just had a look at the models. One problem is that due to the massive scales, the textures for the bigger objects were already far too small. e.g. a 20 metre long fighter had a 1024px texture, while a 10km long station only had a 4096x texture.

I've sized down the textures for the smaller models so that

ultra-light = 512
light = 1024
medium = 2048
heavy = 4096
stations = 4096

even here stations should logically be 8192 by my scheme, which would be absolutely enormous file sizes. I may try lowering the quality rather than the resolution for the station and large ship textures and see if I can get the file sizes down that way.

I'm not sure how / if at all Pioneer does any management of texture loading etc. I get the feeling it's simply loads every single texture when you start a game.

@shadmar
Copy link

shadmar commented May 2, 2013

Ok sounds nice, just update this PR with a new texture, or close it and you merge it in with the rest of the textures?

@shadmar
Copy link

shadmar commented May 2, 2013

One more little issue, the starport was half buried on some planets, might wanna yank it up 10 meters in height?

@outridersol
Copy link
Member Author

Ha, yeah I'll do that. I just responded to a post on the forum asking if it could be lowered cos it looks ugly sticking up like that! :).

Hopefully the Pioneer devs will eventually get around to flattening out / placing on flat ground, the cities.

@shadmar
Copy link

shadmar commented May 2, 2013

Actually there exist some code for that we could maybe use
pioneerspacesim#1476

@outridersol outridersol closed this May 2, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants