-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace updates_made
logic
#509
Comments
"Currently, we have logic to show an "updated_tag" if an event has been updated more recently than the event's agenda." Updated more recently than the Agenda date, or updated since the Agenda was posted/published? |
updated since the agenda was inserted into our system, which is going to be close to when the agenda was posted/published The current logic shows the updated_tag whenever this condition is met, even, possibly for past events. |
Okay, then yes, let's go with the logic of: |
perfect, thanks! |
This is done and available on the test site. https://lametro-upgrade.datamade.us |
#566 may be caused by me not articulating the logic for displaying the "Updated" tag clearly enough in this thread. The logic should be:
|
Hi, @shrayshray. The pieces we have to work with are the date (but not the time) the agenda was published, and the date and time the event was last updated. Events are updated when an agenda is published, so if we compare the agenda date with the event updated date, every event will be marked as "updated" when an agenda is published. We could do something like if an event is updated within three days of the agenda being published, not including the day it's published. Would that work? |
@shrayshray There are some further caveats to using the agenda publishing date, chiefly that we aren't sure it's updated when an agenda is changed from private to public. So, any approach that makes use of the publishing date, including the one I suggested in my last comment, has the potential to behave differently than expected because the date is not reliable. Is there acceptable logic that does not use the agenda publishing date? |
@hancush I have an idea to avoid using the publishing date. What if we looked for updates within 96 hours before the meeting start time? This is enough to get us out of the zone for Friday posting to trigger "Updated" for both Wednesday and Thursday meetings. It's an extremely rare case for updates to be made on Saturday or Sunday; and any edited Report clearly reads "Revised" or "Withdrawn" on the Agenda and Report itself if a change is made during any period of time. Does looking back 96 hours prior to the meeting start time for updates sound feasible? |
@shrayshray That sounds reasonable to me! |
I've implemented this logic and deployed it to the test site, @shrayshray! |
@hancush great! Will keep an eye on it when next month's Agendas are posted and if any changes are made to them before the meeting. |
Currently, we have logic to show an "updated_tag" if an event has been updated more recently than the event's agenda.
This logic is going to be a bit difficult to reproduce exactly with the 2.5 models.
I wonder if if would be acceptable to show a tag that indicated that an event had been updated, in any way, within some time window.
For example, if an upcoming event had been updated in any way (changed time, address, document, agenda item, etc), in the past two or three days, then show the "Updated" tag.
Thoughts, @shrayshray ?
The text was updated successfully, but these errors were encountered: