Move logic to handle missing histories upstream #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hancush
commented
Jan 30, 2020
|
|
||
| # Assert the last action matches the event that has already occurred. | ||
| assert last_action_date == two_weeks_ago | ||
| assert last_action_date.date() == two_weeks_ago.date() |
There was a problem hiding this comment.
I kept this test here because it uses so much of the Metro-specific test infrastructure. It would be ideal to move it upstream, but given our limitations on hours, I thought this would suffice for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
See datamade/django-councilmatic#264.
Related issues
Connects opencivicdata/scrapers-us-municipal#300.
Testing Instructions
docker-compose up -d app.docker-compose exec app python manage.py update_index --age=1 --batch-size=100