Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components with children should accept and render children #78

Closed
jbouder opened this issue Sep 8, 2023 Discussed in #75 · 1 comment
Closed

Components with children should accept and render children #78

jbouder opened this issue Sep 8, 2023 Discussed in #75 · 1 comment
Assignees
Labels
enhancement New feature or request refactor Misc changes to project structure or configuration

Comments

@jbouder
Copy link
Collaborator

jbouder commented Sep 8, 2023

Discussed in #75

Originally posted by jpandersen87 September 7, 2023
Either in addition to, or replacement of existing render logic, components should accept and render children. For example, the accordion component currently only accepts a javascript array of items to render instead of allowing the items to be passed manually as children (ex: <Accordion><AccordionItem>...</AccordionItem></Accordion>).

@jbouder
Copy link
Collaborator Author

jbouder commented Sep 8, 2023

Suggest updating all applicable components to allow either children and a list.

@jbouder jbouder added enhancement New feature or request refactor Misc changes to project structure or configuration labels Sep 8, 2023
@jbouder jbouder self-assigned this Sep 13, 2023
@jbouder jbouder closed this as completed Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor Misc changes to project structure or configuration
Projects
None yet
Development

No branches or pull requests

1 participant