Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSG-1032: Comet USWDS Components with children should allow rendering of React children or a list of items #79

Merged
merged 16 commits into from
Sep 27, 2023
Merged

CSG-1032: Comet USWDS Components with children should allow rendering of React children or a list of items #79

merged 16 commits into from
Sep 27, 2023

Conversation

jbouder
Copy link
Collaborator

@jbouder jbouder commented Sep 13, 2023 •
edited
Loading

Update all applicable components with children to allow providing child content as either a dynamic list or as declarative child components.

Description

  • Updated Accordion, Breadcrumb, ErrorMessages, ProcessList, Side Navigation, Select for dynamic and declarative children
  • Updated unit tests and stories to provide both item and child examples
  • Updated exports

Related Issue

#78

Motivation and Context

  • Provide flexibility when using components with children

How Has This Been Tested?

  • Verified local unit testing and storybook testing

Screenshots (if appropriate):

N/A

@jbouder jbouder added enhancement New feature or request refactor Misc changes to project structure or configuration labels Sep 13, 2023
@jbouder
Update to allow providing single accordion item to accordion. Misc cl…
9061f06 
…eanup.
@jbouder
Update to allow breadcrumb children to be provided as list or children.
d92edb8
@jbouder
Update error messages component to allow both children and a list for…
2d5e8b2 
… rendering. Update props for consistency.
@jbouder
Update process list to support both list and children components.
ac0784a
@jbouder
Fix process list step prop description.
106ecff
@jbouder
Update side navigation to support both items and children.
4d0692d
@jbouder
Fix unit test.
23355cf
@jbouder
Update select to support both items and children.
f92abcf
@jbouder
Update combobox for select updates.
a2aa767
@jbouder
Udpate combobox props for consistency.
afde2ed
@jbouder
Update prop descriptions for consistency.
2f932db
@jbouder
Fix process list prop typo.
e5a317e
@jbouder
Update component exports to include child list item props.
095cb57
@jbouder jbouder marked this pull request as ready for review September 25, 2023 22:44
LuisdelaVega
LuisdelaVega approved these changes Sep 27, 2023
View reviewed changes
Copy link
Collaborator

@LuisdelaVega LuisdelaVega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jbouder jbouder merged commit d7410dc into main Sep 27, 2023
5 checks passed
@jbouder jbouder deleted the CSG-1032 branch September 27, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuisdelaVega LuisdelaVega LuisdelaVega approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request refactor Misc changes to project structure or configuration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbouder @LuisdelaVega