Fix crash during call to CommonMonitor.SetCharacterSlot #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tc21
commented
Feb 8, 2024
Comment on lines
+35
to
+41
| if (!____characterSlotData.ContainsKey(data.MapKey)) | ||
| { | ||
| Console.Log($"Could not get CharacterSlotData for character [Index={data.Index}, MapKey={data.MapKey}], ignoring..."); | ||
| return false; | ||
| } | ||
|
|
||
| return true; |
There was a problem hiding this comment.
突然想到前几天看到的某条推
只要后来人把中间的这行log一删，就会变成有名的spaghetti code（
hykilpikonna
approved these changes
Feb 8, 2024
clansty
pushed a commit
that referenced
this pull request
Dec 2, 2024
…found Fix crash during call to CommonMonitor.SetCharacterSlot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a crash when loading the music selection screen, where the call to retrieve character data to display on top monitor causes a KeyNotFound error. This fix simply doesn't load those characters.
上面小屏幕里的加载不出来的人物会变成空白。但是至少不会崩了……