Add getrandom call on horizon OS #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yeah, it would be good to do this so making the PR to upstream is easier. |
AzureMarker
approved these changes
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref Meziu/rust-horizon#6, rust3ds/shim-3ds#8
Side note: it might be useful to rebase this repo onto upstream again so the version number matches, but perhaps not strictly necessary.
As @Meziu mentioned, this probably won't be the only libc change needed during the course of
stdtesting (I think__errno()might be another one we'd want, as mentioned in rust-lang#1995). It's nice that upstream merged the fork, but maybe we're not ready to switch completely to it just yet.