Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make --no-shell not exit early #402

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Conversation

pbsds
Copy link
Contributor

@pbsds pbsds commented Jun 7, 2024

This makes --no-shell --post-result with multiple PRs post more than just the first report.

nixpkgs_review/cli/pr.py Outdated Show resolved Hide resolved
nixpkgs_review/cli/pr.py Outdated Show resolved Hide resolved
@Mic92 Mic92 force-pushed the no-shell-post-results branch from 3f5f7ca to 29249cb Compare June 8, 2024 06:03
nixpkgs_review/cli/pr.py Outdated Show resolved Hide resolved
This makes `--no-shell --post-result` with multiple PRs post more than just the first report.
@Mic92 Mic92 force-pushed the no-shell-post-results branch from 29249cb to 9fefa1a Compare June 11, 2024 08:49
@Mic92
Copy link
Owner

Mic92 commented Jun 11, 2024

@mergify queue

Copy link
Contributor

mergify bot commented Jun 11, 2024

queue

☑️ GitHub can't merge the pull request for now.

GitHub can't merge the pull request for an unknown reason. You should retry later.

@Mic92
Copy link
Owner

Mic92 commented Jun 11, 2024

@mergify queue

Copy link
Contributor

mergify bot commented Jun 11, 2024

queue

🛑 The pull request has been removed from the queue default

Pull request #402 has been dequeued. GitHub can't merge the pull request for now.. GitHub can't merge the pull request for an unknown reason. You should retry later..

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@Mic92 Mic92 merged commit 59a89e4 into Mic92:master Jun 11, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants