Skip to content

Commit

Permalink
Log exceptions when failing to auto-join new user according to the `a…
Browse files Browse the repository at this point in the history
…uto_join_rooms` option. (element-hq#17176)

Would have been useful for tracking down element-hq#16878.

Signed-off-by: Olivier 'reivilibre <oliverw@matrix.org>
  • Loading branch information
reivilibre authored and Mic92 committed Jun 14, 2024
1 parent a08b072 commit 48de9d6
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions changelog.d/17176.misc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Log exceptions when failing to auto-join new user according to the `auto_join_rooms` option.
2 changes: 1 addition & 1 deletion synapse/handlers/register.py
Original file line number Diff line number Diff line change
Expand Up @@ -590,7 +590,7 @@ async def _join_rooms(self, user_id: str) -> None:
# moving away from bare excepts is a good thing to do.
logger.error("Failed to join new user to %r: %r", r, e)
except Exception as e:
logger.error("Failed to join new user to %r: %r", r, e)
logger.error("Failed to join new user to %r: %r", r, e, exc_info=True)

async def _auto_join_rooms(self, user_id: str) -> None:
"""Automatically joins users to auto join rooms - creating the room in the first place
Expand Down

0 comments on commit 48de9d6

Please sign in to comment.