-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Color palette changes #109
Conversation
Commit this PR, to run a simulation
wrong folder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks very good - well done @fn753 !
What I would suggest to make this PR available in live system few days after the DietPi release. In this way we could more clearly identify the users' response to this change (more like an A/B test).
Furthermore I would suggest committing the change at once with a PR for DietPi-Docs. I suspect MkDocs theme being quite flexible to accommodate new color codes in an easy way.
A review is difficult for me without seeing it preliminarily. |
No need to merge into dev, you can deploy the dev-color branch to the test URL as well. |
Yes, good idea! This I did not memorize. I will do that. |
@StephanStS - Try now the test |
I also did the trigger already (I did it in parallel to you, I hope I did it right), but I don't see any difference. |
Try to reload the page with F5 or CTRL+F5 to trigger the browser validating or clearing the cache respectively. |
I now saw that the button style isn't the same - some are rounded, some are not and the buttons in the slider look completely different. |
I did that without success, also in a different browser, but actually the design is the new one. :-) |
But then it did work, or what is missing? |
to allow better review of actual style changes
Saw it as well. Text colour needs to be changed to white .... done. |
Btw, currently the slider styles are overridden by our |
so that Cloudflare and browser caches are invalidated. And remove a non-fitting colour.
so that browser and Cloudflare caches are invalidated and remove a non-fitting colour, replaced with a code tag.
to invalidate Cloudflare and browser caches.
No description provided.