Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color palette changes #109

Merged
merged 18 commits into from
Jun 10, 2021
Merged

Color palette changes #109

merged 18 commits into from
Jun 10, 2021

Conversation

MichaIng
Copy link
Owner

No description provided.

@MichaIng MichaIng requested review from StephanStS, fpetru and fn753 May 27, 2021 10:44
@MichaIng MichaIng added the enhancement New feature or request label May 27, 2021
Copy link
Collaborator

@fpetru fpetru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks very good - well done @fn753 !

What I would suggest to make this PR available in live system few days after the DietPi release. In this way we could more clearly identify the users' response to this change (more like an A/B test).

Furthermore I would suggest committing the change at once with a PR for DietPi-Docs. I suspect MkDocs theme being quite flexible to accommodate new color codes in an easy way.

@StephanStS
Copy link
Collaborator

A review is difficult for me without seeing it preliminarily.
I propose to merge this PR, then built a preliminary (test) site and check it.

@MichaIng
Copy link
Owner Author

No need to merge into dev, you can deploy the dev-color branch to the test URL as well.

@StephanStS
Copy link
Collaborator

No need to merge into dev, you can deploy the dev-color branch to the test URL as well.

Yes, good idea! This I did not memorize. I will do that.

@fpetru
Copy link
Collaborator

fpetru commented May 30, 2021

A review is difficult for me without seeing it preliminarily.
I propose to merge this PR, then built a preliminary (test) site and check it.

@StephanStS - Try now the test

@StephanStS
Copy link
Collaborator

A review is difficult for me without seeing it preliminarily.
I propose to merge this PR, then built a preliminary (test) site and check it.

@StephanStS - Try now the test

I also did the trigger already (I did it in parallel to you, I hope I did it right), but I don't see any difference.

@MichaIng
Copy link
Owner Author

Try to reload the page with F5 or CTRL+F5 to trigger the browser validating or clearing the cache respectively.

@fn753
Copy link
Collaborator

fn753 commented May 30, 2021

I now saw that the button style isn't the same - some are rounded, some are not and the buttons in the slider look completely different.

@StephanStS
Copy link
Collaborator

Try to reload the page with F5 or CTRL+F5 to trigger the browser validating or clearing the cache respectively.

I did that without success, also in a different browser, but actually the design is the new one. :-)
Another option, which I did not test, would have been to open a "private window". But I had not this idea. :-(

@MichaIng
Copy link
Owner Author

but actually the design is the new one. :-)

But then it did work, or what is missing?

@MichaIng MichaIng linked an issue Jun 3, 2021 that may be closed by this pull request
@StephanStS
Copy link
Collaborator

I saw this which should be corrected, or is it already done?
grafik

@MichaIng
Copy link
Owner Author

MichaIng commented Jun 6, 2021

Saw it as well. Text colour needs to be changed to white .... done.

@MichaIng
Copy link
Owner Author

MichaIng commented Jun 6, 2021

Btw, currently the slider styles are overridden by our style.css, as first I wanted to keep the original jquery.cslider.css untouched. But that is not developed anymore, so I think it's time to move all related styles from style.css into jquery.cslider.css, or depending on size, everything into style.css. But no need to rush this, just FYI that it is okay to edit jquery.cslider.css and remove the overrides from style.css instead.

MichaIng added 5 commits June 9, 2021 17:49
so that Cloudflare and browser caches are invalidated. And remove a non-fitting colour.
so that browser and Cloudflare caches are invalidated and remove a non-fitting colour, replaced with a code tag.
to invalidate Cloudflare and browser caches.
@MichaIng MichaIng merged commit d658d6d into dev Jun 10, 2021
@MichaIng MichaIng deleted the dev-color branch June 10, 2021 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Try to change some of the website colors
4 participants