Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DietPi-Software | Transmission: Stop service before creating config #4972

Merged
merged 3 commits into from
Nov 19, 2021

Conversation

Joulinar
Copy link
Collaborator

While installing Transmission package, we would need to stop the service before we are going to apply our changes. Otherwise they are not taken into account and overwritten be default settings. Not sure if this is something new with Transmission v3.

Status: Ready

  • adjust dietpi-software

Reference:

Commit list/description:

  • DietPi-Software | Transmission - stop service before applying our configuration settings

DietPi-Software | Transmission - stop service before applying our configuration settings
@Joulinar Joulinar added this to the v7.9 milestone Nov 18, 2021
@Joulinar Joulinar requested a review from MichaIng November 18, 2021 19:20
@Joulinar Joulinar self-assigned this Nov 18, 2021
+ DietPi-Software | Stop all services right after their (package/installer) installation, which were stopped between install and config code blocks in DietPi v7.8 an earlier. In all added cases, this is not necessary to fix install issues (as far as tested), but it reduces RAM usage and CPU utilisation during subsequent installs and all those services are (re)started at the end of all installations with in case updated configs anyway.
@MichaIng
Copy link
Owner

I added stopping the service right after package/installer in all cases where one is installed and where it was stopped in v7.7 and earlier between install and config code blocks. Interestingly I did some tests where we usermod the service user after the install, but it didn't cause an issue in any of them even when the service is definitely running with this user. So the user seems to be not generally blocked but only in the four cases I fixed earlier. However, it makes sense to not keep running a service while other installs with high RAM and CPU usage may still happen and when those services are started at the end anyway.

But the live patch is hence only required for Transmission 👍.

@MichaIng MichaIng changed the title DietPi-Software | Transmission DietPi-Software | Transmission: Stop service before creating config Nov 19, 2021
@Joulinar
Copy link
Collaborator Author

Ok perfect 👍

+ CHANGELOG | Transmission: Resolved a v7.8 regression where on fresh Transmission installs the intended configuration was not deployed. Many thanks to `@kannz` and `@alessandro.psrt` for reporting this issue: https://dietpi.com/phpbb/viewtopic.php?t=9567, https://dietpi.com/phpbb/viewtopic.php?t=9683
@MichaIng MichaIng merged commit d74b965 into dev Nov 19, 2021
@MichaIng MichaIng deleted the transmission branch November 19, 2021 17:15
MichaIng added a commit that referenced this pull request Nov 19, 2021
+ DietPi-Live-patches | Fix Transmission install: #4972
MichaIng added a commit that referenced this pull request Nov 19, 2021
+ DietPi-Live-patches | Fix Transmission install: #4972
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants