-
-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DietPi-DDNS | Add provider YDNS #6674
Conversation
NB: Seems that some commits are being brought in with my work even though the dev branch was synched up before I brought the change over from master so might need to redo the PR anyway. |
You can rebase it onto our dev branch, then the commits from our master branch should not appear anymore. But actually they do not hurt either. I anyway would merge our master into our dev at some point. |
Brilliant! Thanks for the feedback :) Also I'm unsure how to build an image for me to test in a VM -- Is there any docs on how best to do that? |
No need to build full images. Just install a regular system and switch software branch to yours afterwards 😉 |
Easiest is to just replace the script on your system: curl -sSfo /boot/dietpi/dietpi-ddns 'https://raw.githubusercontent.com/TDuffinNTU/DietPi/dev/dietpi/dietpi-ddns' You could also switch the whole branch of your current DietPi system, check out the Otherwise you could use our build script to create an image: curl -sSfLO 'https://raw.githubusercontent.com/MichaIng/DietPi/dev/.build/images/dietpi-build'
chmod +x dietpi-build
./dietpi-build -o TDuffinNTU -b dev -m 0 -a 3 to create an RPi 64-bit image with your branch applied. The script is not documented yet, so check out the code for details: https://github.com/MichaIng/DietPi/blob/dev/.build/images/dietpi-build#L53 |
Syntax/typo/spelling corrections. Co-authored-by: MichaIng <micha@dietpi.com>
…was also actual reason YDNS was skipping its domains menu)
Co-authored-by: MichaIng <micha@dietpi.com>
Co-authored-by: MichaIng <micha@dietpi.com>
- CHANGELOG | DietPi-DDNS: YDNS has been added to the list of natively supported DDNS providers. Many thanks to @edmundlaugasson for requesting and @TDuffinNTU for implementing it: MichaIng#5128, MichaIng#6674
Closes #5128
As YDNS expects a single (one and only one) domain in its API request I've added a special case for it in Menu_Domains but this might not be correct (do we submit domains as a list or is it split by the commas and sent in multiple requests?
There are two options for YDNS updating - One uses an auth header and the other uses an "update link" which is a shortened variant of the update URI but with a random token. I opted for the former since I feel that's more secure and easier to fit into the UX of the application.
Remaining in draft until I can spin up a dietpi VM to test this, but welcome to feedback ahead of that.