Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for epub-version parameter in mdbook-epub plugin #122

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

dluschan
Copy link
Contributor

Added Support for epub-version Configuration Parameter in mdbook-epub Plugin

Changes:

  1. Introduced the [output.epub] epub-version configuration parameter, allowing users to specify EPUB version 2 or 3.
  2. Implemented validation to handle unsupported versions with detailed error messages.

src/generator.rs Outdated
let config = Config::from_render_context(ctx)?;

// Проверка epub_version перед созданием builder
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Проверка epub_version перед созданием builder

Some readers won't be able to read the comment, so it's better off without it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done. removed

@blandger blandger merged commit 14395b5 into Michael-F-Bryan:master Oct 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants