Options

[gambhiro]

Hello,

This includes two options I needed, cover-image and additional-resources.

A rough outline of my procedure was:

• start this branch options from master
• merge your work from the template branch
• resolve conflicts
• add the options to specify cover-image and additional-resources

So this includes your work in the Handlebars template branch, with small patches to make it compile, which is effectively PR #8 and PR #26.

It builds an EPUB which passes epubcheck and can be used with kindlegen to generate a MOBI successfully like so:

kindlegen "./book.epub" -dont_append_source -c1 -verbose

When I was resolving the merge conflicts, there was one thing I didn't understand and marked with a FIXME in generator.rs.

Building the epub worked for me without it, but you would probably remember whether it is still relevant.

        /* FIXME: is this logic still necessary?
        // unfortunately we need to do two passes through `ch.sub_items` here.
        // The first pass will add each sub-item to the current chapter's toc
        // and the second pass actually adds the sub-items to the book.
        for sub_item in &ch.sub_items {
            if let BookItem::Chapter(ref sub_ch) = *sub_item {
                let child_path = sub_ch.path.with_extension("html").display().to_string();
                content = content.child(TocElement::new(child_path, format!("{}", sub_ch)));
            }
        }
        */

[Michael-F-Bryan]

I think we needed it because I had issues with items inside nested chapters (or maybe items inside items inside chapters) not showing up in the table of contents. If it works fine for you I'd say it's okay to remove.

You can bump the MSRV in travis.yml to about 1.40.0 to fix the CI error. You may want to add a comment referencing rust-lang/cargo#7579 so we know why that particular version was picked.

Other than that I'm happy to merge the code and make a release.

[gambhiro]

Thanks for the notes.

I ran a quick test just now with a nested chapter structure, and they showed up in the TOC and rendered correctly.