Move to Timeouts #150
Merged
Move to Timeouts #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will review this code after my break. |
|
Sounds good, I also went ahead and added support for multiple guilds, I hope you have a good break 👍. |
|
You forgot to update readme to add the multiple guild. Also, I don't think it's smart to add multiple guild option. This package is a easy to build package soo that people can read the code with ease and learn how to code it themself. About if too add it, idk yet. |
Scraayp
approved these changes
Dec 28, 2021
|
Also the docs are automatic. Just run:
|
|
I updated the docs and the README, thanks for letting me know about JSDocs, I'll probably implement it into my own projects. |
|
Okay, Could you test everything out on a test bot. To make sure everything works, after I get the confirmation of you. I will push the pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This pr aims to move all
mutesto the new Timeout feature DiscordJS v13.4 has. I haven't tested this but it should work. I wish I could edit the docs but I'm not the best with HTML and will leave that for someone to take a look at. I scrapped the unMute function as Discord now handles that.Status and versioning classification: