Use peer_addr of incoming daemon connection for registration
#1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4af82a4.
…f just the port" This reverts commit 1ba763c.
…ocket We are not interested in the local bind address of the daemon. Instead, we want to use the IP address under which the daemon is available from other machines. This should also avoids the issue that connecting to 0.0.0.0 is not possible on Windows (we want to use 0.0.0.0 as default bind address).
This was referenced Apr 17, 2024
Michael-J-Ward
pushed a commit
that referenced
this pull request
Aug 13, 2024
…l-method Add derivation fo python ros2 bridge
Michael-J-Ward
pushed a commit
that referenced
this pull request
Aug 13, 2024
Fix for action PR: Return data from `downcast` function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are not interested in the local bind address of the daemon. Instead, we want to use the IP address under which the daemon is available from other machines.
This should also avoids the issue that connecting to 0.0.0.0 is not possible on Windows (we want to use 0.0.0.0 as default bind address).
Limitations
Note that this solution does not cover port remappings yet. For example, a router between the daemon and the internet might map the daemon's listen port to some other port number. In this case, the port number in the
Registermessage would be incorrect. To fix this, we would need to make the advertised port number configurable independently of the daemon'sbindport number.