Merge pull request #3 from Azure/master

Merge main master branch into MichalHel fork

.azure-pipelines/PrettierCheck.yml

@@ -1,6 +1,5 @@
 jobs:
 - job: "PrettierCheck"
-  condition: "not(variables['PRIVATE'])"
   variables:
     NODE_OPTIONS: '--max-old-space-size=8192'
   pool:

.azure-pipelines/Spellcheck.yml

@@ -1,6 +1,5 @@
 jobs:
 - job: "Spellcheck"
-  condition: "not(variables['PRIVATE'])"
   variables:
     NODE_OPTIONS: '--max-old-space-size=8192'
   pool:

.github/PULL_REQUEST_TEMPLATE.md

@@ -14,6 +14,8 @@ If any further question about AME onboarding or validation tools, please view th
   - Adding a new API version
   - Adding a new service
 
+- [ ] Please ensure you've reviewed following [guidelines](https://aka.ms/rpguidelines) including [ARM resource provider contract](https://github.com/Azure/azure-resource-manager-rpc) and [REST guidelines](https://github.com/microsoft/api-guidelines/blob/vNext/azure/Guidelines.md). Estimated time (4 hours). This is required before you can request review from ARM API Review board.
+
 - [ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (*RP Manifest Approvers* team under <ins>Azure Resource Manager service</ins>) from IcM and reach out to them. 
 
 ### Breaking Change Review Checklist 

.github/comment.yml

@@ -0,0 +1,25 @@
+---
+- rule:
+    type: checkbox
+    keywords:
+      - "WaitForARMFeedback"
+    booleanFilterExpression: "!(ARMSignedOff||ARMChangesRequested||Approved-OkToMerge||WaitForARMRevisit)"
+    onCheckedLabels:
+      - WaitForARMFeedback
+    onCheckedComments: "Hi, @${PRAuthor} your PR are labelled with <b> WaitForARMFeedback</b>. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @${PRAssignee} "
+
+- rule:
+    type: checkbox
+    keywords:
+      - "I have reviewed the [documentation](https://aka.ms/ameonboard) for the workflow."
+    onCheckedComments: "Hi, @${PRAuthor} Thanks for your PR. I am workflow bot for review process. Here are some small tips. </br> <li> Please ensure to do self-check against checklists in first PR comment.</li> <li> PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging. </li>  <li> If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. [How to fix?](https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/ci-fix.md)</li></br> Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com"
+
+- rule:
+    type: label
+    label: BreakingChangeReviewRequired
+    onLabeledComments: "Hi @${PRAuthor}, one or multiple breaking change(s) is detected in your PR. Pls follow [breaking change policy](https://aka.ms/AzBreakingChangesPolicy) to request breaking change review and approval before proceeding swagger PR review. "
+
+- rule:
+    type: label
+    label: ApprovedOkToMerge
+    onLabeledComments: "Hi @${PRAuthor},Your PR is approved. Congratulations. </br> <li> If your PR is in public repo (azure-rest-api-specs),  PR assignee will merge all updates in the PR shortly afterwards; or pause the PR merge, you need to put on a label <b>DoNotMerge</b> to PR as soon as possible. </li><li>If your PR is in private repo (azure-rest-api-specs-pr),  there won’t be PR merge.  Please refer to this [wiki](https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/205/RP-Scenarios-to-Contribute-to-Swagger?anchor=**public-repository-vs.-private-repository**) for further guidance on how to proceed. </li>"

.github/issue_assignment.yml

@@ -4,7 +4,7 @@
     assignees:
       - yungezz
       - erich-wang
-      - NullMDR
+      - PhoenixHe-msft
       - raych1
       - lirenhe
       - weidongxu-microsoft
@@ -19,4 +19,3 @@
       - qianwens
       - ruowan
       - MyronFanQiu
-      - jianyexi

.github/pull_request_assignment.yml

@@ -1,4 +1,11 @@
 ---
+- rule:
+    # eventgrid data-plane PR
+    paths:
+      - "specification/eventgrid/data-plane/**"
+    reviewers:
+      - lmazuel
+
 - rule:
     # data-plane PR
     paths:
@@ -8,32 +15,33 @@
       - jhendrixMSFT
       - lmazuel
       - tjprescott
+
 
 - rule:
     paths:
       - "specification/network/**"
     reviewers:
-      - MyronFanQiu
+      - kairu-ms
       - lirenhe
 
 - rule:
     paths:
       - "specification/@(applicationinsights|operationalinsights)/**"
     reviewers:
-      - MyronFanQiu
+      - kairu-ms
 
+- rule:
+    paths: "specification/@(resources|powerplatform)/**"
+    reviewers:
+      - raych1
+
 - rule:
     paths: "specification/compute/**"
     reviewers:
       - ArcturusZhang
       - fengzhou-msft
       - yungezz
 
-- rule:
-    paths: "specification/@(resources|powerplatform)/**"
-    reviewers:
-      - raych1
-
 - rule:
     paths:
       - "specification/machinelearningservices/**"
@@ -64,7 +72,7 @@
       - "specification/monitor/**"
     reviewers:
       - weidongxu-microsoft
-      - MyronFanQiu
+      - kairu-ms
 
 - rule:
     paths:
@@ -73,11 +81,11 @@
       - qianwens
       - Juliehzl
 
-- rule:
-    paths: "specification/mediaservices/**"
-    reviewers:
-      - allenjzhang
 
+- rule:	
+    paths: "specification/mediaservices/**"	
+    reviewers:	
+      - allenjzhang
 - rule:
     paths:
       - "specification/@(keyvault|notificationhubs)/**"
@@ -89,7 +97,7 @@
     paths:
       - "specification/@(containerservice|containerinstance)/**"
     reviewers:
-      - NullMDR
+      - PhoenixHe-msft
       - fengzhou-msft
       - yungezz
 
@@ -104,7 +112,7 @@
     paths:
       - "specification/portal/**"
     reviewers:
-      - NullMDR
+      - PhoenixHe-msft
 
 - rule:
     paths:
@@ -128,7 +136,25 @@
       - ".azure-pipelines-preproduction/**"
     reviewers:
       - akning-ms
-      - NullMDR
+      - PhoenixHe-msft
+
+- rule:	
+    paths:	
+      - "documentation/**"	
+    reviewers:	
+      - josefree	
+      - akning-ms	
+
+- rule:	
+    paths:	
+      - "**/package.json"	
+      - ".github/**"	
+      - "**/azure-pipelines.yml"	
+      - ".azure-pipelines/**"	
+      - ".azure-pipelines-preproduction/**"	
+    reviewers:	
+      - akning-ms	
+      - PhoenixHe-msft	
       - raych1
 
 - rule:
@@ -138,17 +164,16 @@
     reviewers:
       - yungezz
       - erich-wang
-      - NullMDR
-      - raych1
+      - PhoenixHe-msft
       - lirenhe
       - weidongxu-microsoft
       - ArcturusZhang
       - xccc-msft
+      - raych1
       - ChenTanyi
       - fengzhou-msft
       - njuCZ
       - akning-ms
-      - markcowl
       - leni-msft
       - qianwens
       - ruowan

CODEOWNERS

@@ -1,14 +1,14 @@
 /specification/analysisservices/ @taiwu
 /specification/alertsmanagement/ @ofirmanor @olalavi @erangon @orieldar @ilaizi @shakednai1 @khaboasb @orenhor
 /specification/apimanagement/ @promoisha @solankisamir
-/specification/applicationinsights/ @alexeldeib
+/specification/applicationinsights/ @alexeldeib @reyang @TimothyMothra @ramthi @rajkumar-rangaraj @markwolff @trask @hectorhdzg @lzchen
 /specification/asazure/ @athipp
 /specification/authorization/ @darshanhs90 @stankovski
 /specification/automation/ @vrdmr
 /specification/azsadmin/ @deathly809
 /specification/batch/ @matthchr @xingwu1
 /specification/batchai/ @alexanderyukhanov
-/specification/billing/ @wilcobmsft
+/specification/billing/ @wilcobmsft @asarkar84
 /specification/cdn/ @csmengwan @injyzarif @prakharsharma10
 /specification/cognitiveservices/ @felixwa @yangyuan
 /specification/compute/ @bilaakpan-ms @sandido @dkulkarni-ms @haagha @madewithsmiles @MS-syh2qs @grizzlytheodore @hyonholee @mabhard @danielli90 @smotwani @ppatwa @vikramd-ms @savyasachisamal @yunusm @ZhidongPeng @nkuchta @maheshnemichand @najams @changov
@@ -58,9 +58,9 @@
 /specification/recoveryservicessiterecovery/ @avneeshrai
 /specification/redis/ @siddharthchatrolams @timlovellsmith
 /specification/relay/ @sethmanheim @v-ajnava
-/specification/resources/ @Tiano2017 @rajshah11 @vivsriaus
+/specification/resources/ @Azure/arm-template-deployments @rajshah11 @vivsriaus
 /specification/scheduler/ @pinwang81
-/specification/search/data-plane/ @brjohnstmsft @arv100kri @bleroy
+/specification/search/data-plane/ @brjohnstmsft @arv100kri @bleroy @heaths @AlexGhiondea
 /specification/search/resource-manager/ @abhi1509 @miwelsh @tjacobhi
 /specification/serialconsole/ @amitchat @craigw @asinn826
 /specification/service-map/ @daveirwin1

cSpell.json

@@ -2,7 +2,9 @@
     "version": "0.1",
     "language": "en",
     "words": [
-        "Creds"
+        "Creds",
+        "partiallycompleted",
+        "umls"
     ],
     "dictionaryDefinitions": [
         {
@@ -728,13 +730,24 @@
                 "Fcontoso",
                 "Fpushpins"
             ]
-        }
-        ,
+        },
         {
             "filename": "**/specification/communication/data-plane/Microsoft.CommunicationServicesChat/preview/2020-09-21-preview2/communicationserviceschat.json",
             "words": [
                 "readreceipts"
             ]
+        },
+        {
+            "filename": "**/specification/communication/data-plane/Microsoft.CommunicationServicesAdministration/preview/2020-07-20-preview1/communicationservicesadministration.json",
+            "words": [
+                "areacodes",
+                "locationoptions",
+                "phonenumbers",
+                "phoneplangroups",
+                "phoneplans",
+                "pstn",
+                "unconfiguring"
+            ]
         }
     ]
-}
+}