Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

US538740;Moved-react-scripts-to-devDependencies #16

Merged
merged 1 commit into from
Jul 29, 2024
Merged

US538740;Moved-react-scripts-to-devDependencies #16

merged 1 commit into from
Jul 29, 2024

Conversation

atashpulatov
Copy link

@atashpulatov atashpulatov commented Jul 26, 2024 •
edited
Loading

  1. Synced up the package.json and package-lock.json files which decrease number of flaws from 162 to 12.
  2. Moved react-scripts dependency to devDependencies as a workaround due to 12 false alarm flaws it causes Help, npm audit says I have a vulnerability in react-scripts! facebook/create-react-app#11174.

npm audit is broken for front-end tooling by design
Bad news, but it's true. See here for a longer explanation.

npm audit --production

Screenshot 2024-07-26 at 4 28 04 PM

npm audit

Screenshot 2024-07-26 at 4 27 41 PM

Aran0011
Aran0011 approved these changes Jul 29, 2024
View reviewed changes
Copy link

@Aran0011 Aran0011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dholmblad Dholmblad merged commit 8267a0b into MicroStrategy:master Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niyatishah01 niyatishah01 niyatishah01 approved these changes

@Aran0011 Aran0011 Aran0011 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@atashpulatov @niyatishah01 @Aran0011 @Dholmblad