Delay retrying to send telemetry if an exception is hit #420
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I originally made changes to delay retries on specific exceptions but users are hitting this for more reasons such as working offline, working through a proxy, etc. They see >500 requests in less than a minute in these cases which have taken down their proxy. I don't know any reason why there shouldn't be backoff if there is an exception in general instead of constantly retrying. I made the change to delay no matter the exception. I tested on my personal machine and I stopped seeing the constant retries every second.