Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay retrying to send telemetry if an exception is hit #420

Merged
merged 2 commits into from
Sep 15, 2017
Merged

Delay retrying to send telemetry if an exception is hit #420

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca0a6a7
Delay retrying to send telemetry if an exception is hit
leantk Sep 7, 2017
af83baf
Updated changelog
leantk Sep 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions .../com/microsoft/applicationinsights/internal/channel/common/TransmissionNetworkOutput.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,7 @@ public boolean send(Transmission transmission) {

HttpResponse response = null;
HttpPost request = null;
boolean shouldBackoff = false;
try {
request = createTransmissionPostRequest(transmission);
httpClient.enhanceRequest(request);
Expand All @@ -160,32 +161,32 @@ public boolean send(Transmission transmission) {
}
} catch (ConnectionPoolTimeoutException e) {
InternalLogger.INSTANCE.error("Failed to send, connection pool timeout exception");
shouldBackoff = true;
} catch (SocketException e) {
InternalLogger.INSTANCE.error("Failed to send, socket timeout exception");
// backoff retry if no connection is found
if (e instanceof ConnectException) {
transmissionPolicyManager.suspendInSeconds(TransmissionPolicy.BLOCKED_BUT_CAN_BE_PERSISTED, DEFAULT_BACKOFF_TIME_SECONDS);
}
shouldBackoff = true;
} catch (UnknownHostException e) {
InternalLogger.INSTANCE.error("Failed to send, wrong host address or cannot reach address due to network issues, exception: %s", e.getMessage());
// backoff retry if host unknown
transmissionPolicyManager.suspendInSeconds(TransmissionPolicy.BLOCKED_BUT_CAN_BE_PERSISTED, DEFAULT_BACKOFF_TIME_SECONDS);
shouldBackoff = true;
} catch (IOException ioe) {
InternalLogger.INSTANCE.error("Failed to send, exception: %s", ioe.getMessage());
// backoff retry if no connection is found
if (ioe instanceof ConnectTimeoutException) {
transmissionPolicyManager.suspendInSeconds(TransmissionPolicy.BLOCKED_BUT_CAN_BE_PERSISTED, DEFAULT_BACKOFF_TIME_SECONDS);
}
shouldBackoff = true;
} catch (Exception e) {
InternalLogger.INSTANCE.error("Failed to send, unexpected exception: %s", e.getMessage());
shouldBackoff = true;
} catch (Throwable t) {
InternalLogger.INSTANCE.error("Failed to send, unexpected error: %s", t.getMessage());
shouldBackoff = true;
}
finally {
if (request != null) {
request.releaseConnection();
}
httpClient.dispose(response);
// backoff before trying again
if (shouldBackoff) {
transmissionPolicyManager.suspendInSeconds(TransmissionPolicy.BLOCKED_BUT_CAN_BE_PERSISTED, DEFAULT_BACKOFF_TIME_SECONDS);
}
}
}

Expand Down