-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify middleware order and add backchannel injection sample #1331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding @corinagum for code review. |
corinagum
approved these changes
Nov 30, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, pending nitpick updates.
compulim
force-pushed
the
sample-inject-backchannel
branch
from
December 5, 2018 22:52
2dfae87
to
2b8f01b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1430
Background
We want to enable custom middleware to modify existing behavior of saga. For example,
DIRECT_LINE/POST_ACTIVITY
In order to enable this work, we need to tweak the middleware order. Moving custom middleware up will enable more scenarios, and should not disable any existing scenarios (because it is already at the bottom of the stack).
The sample would modify Redux action using custom middleware, and fed into saga for further processing (i.e. send it out).
Will fix #1430.
CHANGELOG.md
Changed
Fixed
Samples
POST_ACTIVITY
, in #1331