Fixed textarea overflow #1986
Merged
Fixed textarea overflow #1986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdurnford
requested review from
a-b-r-o-w-n,
compulim,
corinagum,
cwhitten,
justinwilaby and
tonyanziano
as code owners
compulim
reviewed
May 16, 2019
| whiteSpace: 'pre-wrap', | ||
| width: 'inherit', | ||
| wordBreak: 'break-word' |
There was a problem hiding this comment.
Should we following styleOptions.messageActivityWordBreak? @corinagum what do you think?
If yes, should we add more tests?
There was a problem hiding this comment.
hmmm good point. However, if it's not 'break-word' it creates undesired behavior so I think we would want it to stay on 'break-word' always.
Thoughts?
There was a problem hiding this comment.
My brain stuck last week. Please keep break-word.
compulim
approved these changes
May 20, 2019
| whiteSpace: 'pre-wrap', | ||
| width: 'inherit', | ||
| wordBreak: 'break-word' |
There was a problem hiding this comment.
My brain stuck last week. Please keep break-word.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1980
Changelog Entry
Fix #1980. Changed sendBoxTextArea styles to break words longer than the textarea, by @tdurnford in PR #1986
Description
Set the sendBoxTextArea's 'word-break' style option to 'break-word,' so that text wider than the textarea will wrap to the next line.