Deployment Item support in .NET Core #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
cltshivash
reviewed
Feb 8, 2019
src/Adapter/PlatformServices.Shared/netstandard1.3/Utilities/ns13DeploymentUtilityBase.cs
Show resolved
Hide resolved
cltshivash
reviewed
Feb 8, 2019
src/Adapter/PlatformServices.Shared/netstandard1.3/Utilities/ns13DeploymentUtilityBase.cs
Outdated
Show resolved
Hide resolved
cltshivash
reviewed
Feb 8, 2019
src/Adapter/PlatformServices.Desktop/Utilities/DeploymentUtility.cs
Outdated
Show resolved
Hide resolved
cltshivash
reviewed
Feb 8, 2019
src/Adapter/PlatformServices.Desktop/PlatformServices.Desktop.csproj
Outdated
Show resolved
Hide resolved
cltshivash
reviewed
Feb 8, 2019
src/Adapter/PlatformServices.NetCore/Utilities/AssemblyUtility.cs
Outdated
Show resolved
Hide resolved
abhishkk
changed the title
|
Please write RFC for this support. Currently we don't have documentation for DeploymentItem in mstest v2. So, write RFC for entire DeploymentItem support. |
|
Sign CLA agreement |
abhishkk
reviewed
Feb 8, 2019
src/Adapter/PlatformServices.Shared/netstandard1.3/Resources/Resource.Designer.cs
Show resolved
Hide resolved
As this resource file is moved to another path and also linking i used in csproj for this resource file, please validate whether resources from this file is appearing correctly in .NET desktop and .NET core for scenarios Refers to: src/Adapter/PlatformServices.Shared/netstandard1.3/Resources/Resource.resx:62 in 16739e0. [](commit_id = 16739e0, deletion_comment = False) |
abhishkk
reviewed
Feb 8, 2019
abhishkk
reviewed
Feb 8, 2019
abhishkk
reviewed
Feb 8, 2019
abhishkk
reviewed
Feb 8, 2019
src/Adapter/PlatformServices.Shared/netstandard1.3/Services/ns13TestContextPropertyStrings.cs
Outdated
Show resolved
Hide resolved
abhishkk
reviewed
Feb 8, 2019
src/Adapter/PlatformServices.Shared/netstandard1.3/Services/ns13TestContextPropertyStrings.cs
Outdated
Show resolved
Hide resolved
validated |
…into depItemNetCore
…into depItemNetCore
…into depItemNetCore
jayaranigarg
suggested changes
Feb 12, 2019
src/Adapter/PlatformServices.Desktop/Deployment/AssemblyLoadWorker.cs
Outdated
Show resolved
Hide resolved
src/Adapter/PlatformServices.Desktop/PlatformServices.Desktop.csproj
Outdated
Show resolved
Hide resolved
src/Adapter/PlatformServices.Desktop/PlatformServices.Desktop.csproj
Outdated
Show resolved
Hide resolved
src/Adapter/PlatformServices.Desktop/PlatformServices.Desktop.csproj
Outdated
Show resolved
Hide resolved
src/Adapter/PlatformServices.Desktop/Services/DesktopTestContextImplementation.cs
Outdated
Show resolved
Hide resolved
src/Adapter/PlatformServices.NetCore/Utilities/RecursiveDirectoryPath.cs
Outdated
Show resolved
Hide resolved
src/Adapter/PlatformServices.Shared/netstandard1.0/Services/ns10TestContextPropertyStrings.cs
Show resolved
Hide resolved
src/Adapter/PlatformServices.Shared/netstandard1.3/Services/ns13TestContextPropertyStrings.cs
Outdated
Show resolved
Hide resolved
src/Adapter/PlatformServices.Shared/netstandard1.3/Utilities/ns13DeploymentUtilityBase.cs
Outdated
Show resolved
Hide resolved
src/Adapter/PlatformServices.Desktop/PlatformServices.Desktop.csproj
Outdated
Show resolved
Hide resolved
src/Adapter/PlatformServices.NetCore/Deployment/AssemblyLoadWorker.cs
Outdated
Show resolved
Hide resolved
ankit-nitd-zz
force-pushed
the
depItemNetCore
branch
from
36cdc44
to
54f15b1
Compare
…into depItemNetCore
…into depItemNetCore
…into depItemNetCore
src/Adapter/PlatformServices.Desktop/Utilities/DesktopAssemblyUtility.cs
Outdated
Show resolved
Hide resolved
src/Adapter/PlatformServices.NetCore/Services/NetCoreFileOperations.cs
Outdated
Show resolved
Hide resolved
src/Adapter/PlatformServices.NetCore/Services/NetCoreTestSourceHost.cs
Outdated
Show resolved
Hide resolved
src/Adapter/PlatformServices.NetCore/Utilities/NetCoreDeploymentUtility.cs
Show resolved
Hide resolved
src/Adapter/PlatformServices.NetCore/Utilities/NetCoreDeploymentUtility.cs
Outdated
Show resolved
Hide resolved
src/Adapter/PlatformServices.Shared/netstandard1.3/Services/ns13TestDeployment.cs
Show resolved
Hide resolved
singhsarab
reviewed
Mar 27, 2019
singhsarab
reviewed
Mar 27, 2019
src/Adapter/PlatformServices.NetCore/Utilities/NetCoreDeploymentUtility.cs
Show resolved
Hide resolved
jayaranigarg
approved these changes
Mar 29, 2019
...ests/TestAssets/DeploymentTestProjectNetCore/Properties/PublishProfiles/FolderProfile.pubxml
Outdated
Show resolved
Hide resolved
...latformServices.Shared.Unit.Tests/netstandard1.3/Utilities/ns13DeploymentItemUtilityTests.cs
Outdated
Show resolved
Hide resolved
This was referenced Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing deployment Item functionality in net core