Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment Item support in .NET Core #565

Merged
merged 36 commits into from
Apr 2, 2019

Conversation

ankit-nitd-zz
Copy link

Implementing deployment Item functionality in net core

@msftclas
Copy link

msftclas commented Feb 8, 2019

CLA assistant check
All CLA requirements met.

@abhishkk abhishkk changed the title depItemInNetcoreWithoutUT Deployment Item support in .NET Core Feb 8, 2019
@abhishkk
Copy link
Contributor

abhishkk commented Feb 8, 2019

Please write RFC for this support. Currently we don't have documentation for DeploymentItem in mstest v2. So, write RFC for entire DeploymentItem support.

@abhishkk
Copy link
Contributor

abhishkk commented Feb 8, 2019

Sign CLA agreement

@abhishkk
Copy link
Contributor

abhishkk commented Feb 8, 2019

<xsd:schema id="root" xmlns="" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:msdata="urn:schemas-microsoft-com:xml-msdata">

As this resource file is moved to another path and also linking i used in csproj for this resource file, please validate whether resources from this file is appearing correctly in .NET desktop and .NET core for scenarios


Refers to: src/Adapter/PlatformServices.Shared/netstandard1.3/Resources/Resource.resx:62 in 16739e0. [](commit_id = 16739e0, deletion_comment = False)

@abhishkk
Copy link
Contributor

abhishkk commented Feb 8, 2019

As we have moved files and used linking, can you check that resources are working fine for another language?


Refers to: src/Adapter/PlatformServices.Shared/netstandard1.3/Resources/xlf/Resource.ja.xlf:1 in 16739e0. [](commit_id = 16739e0, deletion_comment = False)

@ankit-nitd-zz
Copy link
Author

<xsd:schema id="root" xmlns="" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:msdata="urn:schemas-microsoft-com:xml-msdata">

As this resource file is moved to another path and also linking i used in csproj for this resource file, please validate whether resources from this file is appearing correctly in .NET desktop and .NET core for scenarios

Refers to: src/Adapter/PlatformServices.Shared/netstandard1.3/Resources/Resource.resx:62 in 16739e0. [](commit_id = 16739e0, deletion_comment = False)

validated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants