Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for CancellationTokenSource in TestContext to help in timeout… #585

Merged
merged 4 commits into from
Mar 28, 2019

Conversation

cltshivash
Copy link
Contributor

Support for CancellationTokenSource in TestContext to help in timeout scenario

@acesiddhu
Copy link
Contributor

do we have a RFC for this change?

@cltshivash
Copy link
Contributor Author

do we have a RFC for this change?

Yes will author one.

@jayaranigarg
Copy link
Member

I would encourage you to add E2E test for the scenario which shows how can user leverage this CancellationToken.

@cltshivash
Copy link
Contributor Author

I would encourage you to add E2E test for the scenario which shows how can user leverage this CancellationToken.

Added E2E tests

@@ -317,4 +317,7 @@ Error: {1}</value>
<data name="UTA_TestMethodExpectedParameters" xml:space="preserve">
<value>Only data driven test methods can have parameters. Did you intend to use [DataRow] or [DynamicData]?</value>
</data>
<data name="Execution_Test_Cancelled" xml:space="preserve">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please xlf file changes associated with this change

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run command "build.cmd -uxlf". You would have to commit the xlf files changes post running the script.

namespace TimeoutTestProject
{
[TestClass]
public class TerimnateLongRunningTasksUsingTokenTestClass
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TerimnateLongRunningTasksUsingTokenTestClass [](start = 17, length = 44)

Nit: Terminate

@cltshivash cltshivash merged commit 1990568 into microsoft:master Mar 28, 2019
@singhsarab
Copy link
Contributor

@cltshivash Can you please add an RFC for this. If added already, please add the link here. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants