Support for CancellationTokenSource in TestContext to help in timeout… #585
Conversation
|
do we have a RFC for this change? |
Yes will author one. |
test/UnitTests/PlatformServices.Desktop.Unit.Tests/Services/DesktopThreadOperationsTests.cs
Show resolved
Hide resolved
src/Adapter/PlatformServices.Desktop/Services/DesktopThreadOperations.cs
Outdated
Show resolved
Hide resolved
src/Adapter/PlatformServices.Shared/netstandard1.0/Services/ns10TestContextImplementation.cs
Show resolved
Hide resolved
test/UnitTests/PlatformServices.Shared.Unit.Tests/netstandard1.0/ns10ThreadOperationsTests.cs
Show resolved
Hide resolved
|
I would encourage you to add E2E test for the scenario which shows how can user leverage this CancellationToken. |
Added E2E tests |
| @@ -317,4 +317,7 @@ Error: {1}</value> | |||
| <data name="UTA_TestMethodExpectedParameters" xml:space="preserve"> | |||
| <value>Only data driven test methods can have parameters. Did you intend to use [DataRow] or [DynamicData]?</value> | |||
| </data> | |||
| <data name="Execution_Test_Cancelled" xml:space="preserve"> | |||
There was a problem hiding this comment.
Please xlf file changes associated with this change
There was a problem hiding this comment.
Run command "build.cmd -uxlf". You would have to commit the xlf files changes post running the script.
| namespace TimeoutTestProject | ||
| { | ||
| [TestClass] | ||
| public class TerimnateLongRunningTasksUsingTokenTestClass |
There was a problem hiding this comment.
TerimnateLongRunningTasksUsingTokenTestClass [](start = 17, length = 44)
Nit: Terminate
|
@cltshivash Can you please add an RFC for this. If added already, please add the link here. Thanks. |
Support for CancellationTokenSource in TestContext to help in timeout scenario