Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship require.js and jquery in Renderer extension #11671

Closed
DonJayamanne opened this issue Oct 16, 2022 · 1 comment · Fixed by #11672 or microsoft/vscode-notebook-renderers#128
Closed
Assignees
Labels
debt Code quality issues
Milestone

Comments

@DonJayamanne
Copy link
Contributor

DonJayamanne commented Oct 16, 2022

Use the new vscode API to ship pre-loads for Notebook renderers.

@DonJayamanne DonJayamanne added the debt Code quality issues label Oct 16, 2022
@DonJayamanne DonJayamanne added this to the October 2022 milestone Oct 16, 2022
@DonJayamanne DonJayamanne self-assigned this Oct 16, 2022
@DonJayamanne
Copy link
Contributor Author

Testing

  • Create a jupyter notebook and ensure the following python dependencies are installed in the Python environment
!pip install mobilechelonian plotly plotly-express
  • Verify require.js
    • Create a cell with the following code and run it
import plotly.express as px

fig = px.scatter(x=[0,1,2,3,4],y=[2,4,7,2,7])
fig.show(renderer='notebook')
* [ ] Verify the plot is rendered
  • Verify jQuery
    • Create a cell with the following code and run it
from mobilechelonian import Turtle
t = Turtle()
t.speed(5)
colours=["red","blue","yellow","brown","black","purple","green"]

t.penup(); t.left(90); t.forward(200);t.right(90);t.pendown()
for i in range (0,18):
    t.pencolor(colours[i%7])
    t.right(20)
    t.forward(50)

t.right(180)
t.home()
* [ ] Verify the plot is rendered

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues
Projects
None yet
1 participant