Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hover Documentation Pop up does not work after VSCode 1.52 update #4218

Closed
canersnli opened this issue Dec 11, 2020 · 17 comments
Closed

Hover Documentation Pop up does not work after VSCode 1.52 update #4218

canersnli opened this issue Dec 11, 2020 · 17 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug

Comments

@canersnli
Copy link

Environment data

  • VS Code version: 1.52.0
  • Jupyter Extension version (available under the Extensions sidebar): v2020.12.414227025
  • Python Extension version (available under the Extensions sidebar): v2020.11.371526539
  • OS (Windows | Mac | Linux distro) and version: Windows10
  • Python and/or Anaconda version: 3.8.5
  • Type of virtual environment used (N/A | venv | virtualenv | conda | ...): conda
  • Jupyter server running: Local | Remote | N/A Local
  • Microsoft Language Server: Pylance v2020.12.2

Expected behaviour

In ipynb files, on hover, showing documentation pop-up

Actual behaviour

Right after VSCode 1.52 update , on hover documentation pop-up stopped working, nothing pops up. I have downgraded from 1.52 to 1.51.1 and bug has been solved.

Steps to reproduce:

[NOTE: Self-contained, minimal reproducing code samples are extremely helpful and will expedite addressing your issue]

Logs

Output for Jupyter in the Output panel (ViewOutput, change the drop-down the upper-right of the Output panel to Jupyter)

XXX

@canersnli canersnli added the bug Issue identified by VS Code Team member as probable bug label Dec 11, 2020
@claudiaregio
Copy link
Contributor

Thanks @canersnli , I am able to repro this in stable.

@greazer
Copy link
Member

greazer commented Jan 4, 2021

Sounds like a regression.

@luiztauffer
Copy link

so, it looks like #4299 was merged and possibly solved this? When is a patch release planned?

@rchiodo
Copy link
Contributor

rchiodo commented Jan 11, 2021

Sometime this month I believe.

@luiztauffer
Copy link

I found that I was having autocompletion error in Ipython and Jupyter and found this Issue: ipython/ipython#12740

pip install jedi==0.17.2 solved for me, also within VSCode

@canersnli
Copy link
Author

I found that I was having autocompletion error in Ipython and Jupyter and found this Issue: ipython/ipython#12740

pip install jedi==0.17.2 solved for me, also within VSCode

Thanks for the advice but it didn't work for me.

@joyceerhl
Copy link
Contributor

Validated with numpy documentation popup in debug bits.

@canersnli
Copy link
Author

canersnli commented Feb 14, 2021

Unfortunately hover pop-up documentation still does not work on VS Code 1.53.2
On top of that, when I downgraded to 1.51.1 to recover pop-up documentation, surprisingly it didn't work either.

Then I switched between VS Code 1.50.1 - 1.51.1 - 1.53.2 and all language servers ( Pylance, Jedi, Microsoft) combinations but I couldn't recover hover documentation pop-up.
@joyceerhl Can you please share working versions of anaconda, python and extensions ? Any other suggestions are welcome aswell.

Edit: After switched between versions and tried all combinations, finally when I upgraded VS Code from 1.50.1 to 1.51.1 hover documentation pop-up worked on Pylance language server. I think I will stay on 1.51.1 for a while :)

@OmarArain
Copy link

I am on VS Code 1.53.2 (Win 10) and I hover pop-up documentation is not working for me either while trying to write Python code.

@arribass
Copy link

I 'm on VS Code 1.54.1 and hover pop-up docs are not working either. Is there any solution in this topic? Insiders works fine in this matters.

@rchiodo
Copy link
Contributor

rchiodo commented Mar 11, 2021

@oag335 and @arribass can you log new issues? It's not clear whether you're talking about ipynb files, whether or not you have pylance installed, and what UI you are seeing this in (pylance is required for the new native notebook UI).

@arribass
Copy link

I have pylance and I'm using an ipynb file. This is what i see when i try to get the docstrings from a function inside a modelu.
The first one is from VS Code Insiders which works pretty fine.
Captura de pantalla (22)
Captura de pantalla (23)

@rchiodo
Copy link
Contributor

rchiodo commented Mar 11, 2021

Yeah I repro that too. Your best bet is to use insiders. We're moving to that new UI eventually so we likely won't fix this in the old UI.

@arribass
Copy link

Okey, in insiders it only works properly when coding on the same cell you have imported the module. If you try to get the docstrings in any other cell it won't show up.

@rchiodo
Copy link
Contributor

rchiodo commented Mar 11, 2021

Weird. That sounds like a separate issue. Not sure why the separate cell would matter. As far as the language server is concerned, the entire notebook is one big py file. I'll log a separate issue. I repro this too.

@arribass
Copy link

Thanks. Where can I find that issue? So I can post some snaps with the errors.

@rchiodo
Copy link
Contributor

rchiodo commented Mar 12, 2021

#5129

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

8 participants