Fix hover regression in webview editor

[rchiodo]

For #4218

Root cause was the structure returned by the language server did not show 'hasOwnProperty' as true even though the field was present.

• Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
• Title summarizes what is changing.
• Has a news entry file (remember to thank yourself!).
• Appropriate comments and documentation strings in the code.
• Has sufficient logging.
• Has telemetry for enhancements.
• Unit tests & system/integration tests are added/updated.
• Test plan is updated as appropriate.
• package-lock.json has been regenerated by running npm install (if dependencies have changed).

[rchiodo]

This isn't necessary for functional tests and was intermittently failing.

[DonJayamanne]

I added them with the intention of keeping all actions consistently the same...
Else it was getting too difficult to figure out what was reqquired
hate this copy paste nonense...

[DonJayamanne]

The new condition is sufficient (strings as any).kind, won't need hasOwnProperty

[rchiodo]

That's not true as (strings as any).kind will resolve as false if the value is 0 or false. I want it to continue to work if the property happens to be there.

[IanMatthewHuff]

Doesn't 'in' keyword work here? 'kind' in strings.

[rchiodo]

Let me double check

[rchiodo]

Yes that seems to work. Not sure what the difference is. I assumed 'in' used hasOwnProperty under the covers.

[IanMatthewHuff]

@rchiodo Heh, I only know because I'd been going through a JS basics book (felt like there was stuff that I didn't know jumping directly into TS) and just read the chapter covering JS object. hasOwnProperty is only checking the top level object prototype for the property, so if it's inherited it won't show up. 'in' keywork checkes the entire property chain. So for an object hasOwnProperty('toString') return false, since that method is in the base object prototype. kind must not be on the top object for some of those string types.

[DonJayamanne]

Might as well remove the check for hasOwnProperty

[codecov-io]

Codecov Report

Merging #4299 (371be65) into main (e38708f) will increase coverage by 4%.
The diff coverage is 50%.

@@           Coverage Diff           @@
##            main   #4299     +/-   ##
=======================================
+ Coverage     70%     75%     +4%     
=======================================
  Files        389     389             
  Lines      25445   25456     +11     
  Branches    3637    3639      +2     
=======================================
+ Hits       18046   19191   +1145     
+ Misses      5996    4781   -1215     
- Partials    1403    1484     +81     

Impacted Files	Coverage Δ
...ence/interactive-common/intellisense/conversion.ts	62% <50%> (ø)
...t/common/variables/environmentVariablesProvider.ts	77% <0%> (-4%)	⬇️
src/client/common/process/pythonDaemonPool.ts	80% <0%> (-3%)	⬇️
...er/jupyterInterpreterSubCommandExecutionService.ts	88% <0%> (-2%)	⬇️
src/client/datascience/jupyter/notebookStarter.ts	77% <0%> (-2%)	⬇️
...active-common/intellisense/intellisenseDocument.ts	67% <0%> (-1%)	⬇️
src/client/datascience/liveshare/liveshare.ts	66% <0%> (ø)
...ient/datascience/jupyter/kernels/kernelSelector.ts	80% <0%> (ø)
.../datascience/interactive-common/synchronization.ts	84% <0%> (ø)
...ience/interactive-common/interactiveWindowTypes.ts	100% <0%> (ø)
... and 75 more