Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactive window not started with active interpreter after changing active interpreters #7301

Closed
joyceerhl opened this issue Aug 26, 2021 · 1 comment · Fixed by #7302
Closed
Labels
bug Issue identified by VS Code Team member as probable bug interactive-window Impacts interactive window

Comments

@joyceerhl
Copy link
Contributor

  1. Pick an interpreter
  2. Start the IW. IW gets started with the right interpreter
  3. Switch interpreters
  4. Close the IW
  5. Reopen the IW
  6. 🐛 IW doesn't get started with the new interpreter. Uses the originally selected interpreter instead.
@joyceerhl joyceerhl added bug Issue identified by VS Code Team member as probable bug interactive-window Impacts interactive window labels Aug 26, 2021
@joyceerhl
Copy link
Contributor Author

Root cause is we're caching the active interpreter controller at the notebookControllerManager level, and we never clear it out when the interpreter is changed. We're already caching the active interpreter at the pythonApi level and invalidating it when the interpreter changes, so I don't think caching the active interpreter controller in the notebookControllerManager buys us anything here.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug interactive-window Impacts interactive window
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant