Do not cache active interpreter controller in notebookControllerManager #7302
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7301
Root cause is we were caching the controller corresponding to the active interpreter and never clearing it out when the interpreter changes. I don't think we should be caching the active interpreter controller in the controllerManager because it's already cached in the pythonApi (and the pythonApi class also already bears responsibility for clearing out its cache on an interpreter change), so we would be duplicating the same code in two spots for no real benefit.
Also fixed a bug with our logic to preload the kernel corresponding to the active interpreter. It was always preloading the interactive controller, not the jupyter-notebook controller.