Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with Pylance/autocompletion in new interactive window #7406

Closed
stevenlis opened this issue Sep 3, 2021 · 13 comments
Closed

Issue with Pylance/autocompletion in new interactive window #7406

stevenlis opened this issue Sep 3, 2021 · 13 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug interactive-window Impacts interactive window notebook-intellisense Intellisense & other language features in notebook cells for any language verified Verification succeeded
Milestone

Comments

@stevenlis
Copy link

Version: 1.60.0 (user setup)
Commit: e7d7e9a9348e6a8cc8c03f877d39cb72e5dfb1ff
Date: 2021-09-01T10:41:52.311Z
Electron: 13.1.8
Chrome: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Windows_NT x64 10.0.19043
Extension: v2021.9.0
  1. %config Completer.use_jedi = False is no longer working, so no Jupyter autocompletion is enabled and no autocompletion for column names when using dot notation.
    Auto complete for file/path name and pandas column name with bracket access pylance-release#851
    Autocomplete hangs the kernel for interactive window #1300
    6k5EIihGuE

  2. The code entering field is fixed at the bottom, so the autocompletion blocks your code completely sometimes.
    Snipaste_220
    Snipaste_294

  3. unnecessary checking
    image

@stevenlis stevenlis added the bug Issue identified by VS Code Team member as probable bug label Sep 3, 2021
@claudiaregio
Copy link
Contributor

Thanks @StevenLi-DS, will discuss at next triage meeting

@stevenlis
Copy link
Author

May I know why %config Completer.use_jedi = False is no longer working? I thought it is just Jupyter notebook settings.

@greazer greazer assigned rchiodo and unassigned claudiaregio Sep 9, 2021
@greazer greazer added this to the September 2021 milestone Sep 9, 2021
@greazer greazer added the notebook-intellisense Intellisense & other language features in notebook cells for any language label Sep 9, 2021
@rchiodo
Copy link
Contributor

rchiodo commented Sep 9, 2021

This looks to be a bug in our autocomplete for the interactive window. We aren't asking jupyter for any autocomplete in the input box anymore.

@stevenlis
Copy link
Author

Is there a current workaround for the second issue I mentioned above?

The code entering field is fixed at the bottom, so the autocompletion blocks your code completely sometimes.

@rchiodo
Copy link
Contributor

rchiodo commented Sep 22, 2021

The code entering field is fixed at the bottom, so the autocompletion blocks your code completely sometimes.

Sorry not sure what you're referring to when you say it blocks your code? You mean it comes up on top of it visually? AFAIK this is by design

@stevenlis
Copy link
Author

You mean it comes up on top of it visually?

Yes. I think the current design didn't take consideration of the fact that the code entering field is fixed in the lower right corner. It seems like this is a general issue in vscode if you type code in the lower right position.
TBiSMCWVMm
FAlQQVZS61

@rchiodo
Copy link
Contributor

rchiodo commented Sep 22, 2021

Thanks. I created a new issue in VS code for that:
microsoft/vscode#133622

@stevenlis
Copy link
Author

stevenlis commented Oct 12, 2021

@rchiodo 3. unnecessary checking is really annoying, and you have no way to stop it once it's somehow triggered. It underlines my code even if I enter something like df.head(). Could you guys at least add a toggle or something, I can disable this checking in the interactive window for good?

@rchiodo
Copy link
Contributor

rchiodo commented Oct 12, 2021

@rchiodo 3. unnecessary checking is really annoying, and you have no way to stop it once it's somehow triggered. It underlines my code even if I enter something like df.head(). Could you guys at least add a toggle or something, I can disable this checking in the interactive window for good?

You'd have to disable intellisense altogether (it's a bug). If you switch to 'jedi' as the language server for python code, those squiggles won't show up.

@stevenlis
Copy link
Author

@rchiodo Is this a known issue and logged on your end?

@rchiodo
Copy link
Contributor

rchiodo commented Oct 12, 2021

Other than in this issue, I don't think we have a separate bug for it. Looks like there's a newline problem in the concatenation of the cells as we pass them to pylance.

@rchiodo
Copy link
Contributor

rchiodo commented Oct 25, 2021

2nd issue is actually covered by this #8021

@rchiodo
Copy link
Contributor

rchiodo commented Oct 27, 2021

Intellisense should be working again in the insiders version.

@rchiodo rchiodo closed this as completed Oct 27, 2021
@DonJayamanne DonJayamanne added the verified Verification succeeded label Oct 27, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug interactive-window Impacts interactive window notebook-intellisense Intellisense & other language features in notebook cells for any language verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants