Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for jupyter autocomplete back to the IW #8035

Merged
merged 2 commits into from
Oct 25, 2021

Conversation

rchiodo
Copy link
Contributor

@rchiodo rchiodo commented Oct 25, 2021

For #7406

Jupyter autocomplete was not enabled for the interactive window after we switched its implementation. This reenables it.

@rchiodo rchiodo requested a review from a team as a code owner October 25, 2021 21:58
@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2021

Codecov Report

Merging #8035 (df89633) into main (9c830c5) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff          @@
##            main   #8035   +/-   ##
=====================================
- Coverage     70%     70%   -1%     
=====================================
  Files        367     367           
  Lines      22606   22603    -3     
  Branches    3425    3427    +2     
=====================================
- Hits       16045   16020   -25     
- Misses      5181    5196   +15     
- Partials    1380    1387    +7     
Impacted Files Coverage Δ
src/client/common/utils/misc.ts 62% <100%> (ø)
src/client/datascience/notebook/helpers/helpers.ts 56% <100%> (+<1%) ⬆️
src/client/datascience/notebook/integration.ts 100% <100%> (ø)
...ence/notebook/intellisense/intellisenseProvider.ts 86% <100%> (-2%) ⬇️
...notebook/intellisense/jupyterCompletionProvider.ts 64% <100%> (-1%) ⬇️
...ience/variablesView/variableViewMessageListener.ts 77% <0%> (-23%) ⬇️
...ent/common/application/webviewViews/webviewView.ts 67% <0%> (-11%) ⬇️
...ent/datascience/jupyter/pythonVariableRequester.ts 64% <0%> (-6%) ⬇️
...client/datascience/kernel-launcher/kernelDaemon.ts 56% <0%> (-2%) ⬇️
src/client/datascience/jupyter/kernels/kernel.ts 75% <0%> (-2%) ⬇️
... and 4 more

@rchiodo rchiodo merged commit 864e8ed into main Oct 25, 2021
@rchiodo rchiodo deleted the rchiodo/jupyter_intellisense_iw branch October 25, 2021 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants