Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UX: align file names when renaming #27393

Closed
wangweixuan opened this issue May 28, 2017 · 5 comments
Closed

UX: align file names when renaming #27393

wangweixuan opened this issue May 28, 2017 · 5 comments
Assignees
@isidorn
Labels
feature-request Request for new features or functionality file-explorer Explorer widget issues help wanted Issues identified as good community contribution opportunities *out-of-scope Posted issue is not in scope of VS Code ux User experience issues
Milestone
Backlog

Comments

@wangweixuan
Copy link

When renaming a file or a folder in the explorer sidebar, you can see that its name has an offset of 1px because of the border of the input box. Although that's trivial, it is something interrupting for me. May we make the input box move left 1px so that the names will be aligned?
@bpasero bpasero added file-explorer Explorer widget issues feature-request Request for new features or functionality labels May 28, 2017
@mjbvz mjbvz added help wanted Issues identified as good community contribution opportunities ux User experience issues labels Nov 9, 2017
@ergunsh ergunsh mentioned this issue Feb 11, 2018
Merged
@isidorn isidorn added this to the February 2018 milestone Feb 13, 2018
isidorn added a commit that referenced this issue Feb 13, 2018
@isidorn
Merge pull request #43443 from ergun1017/feature/align-file-names-whe…
8d4c824 
…n-renaming

Adresses #27393 - Added margin-left: -1px to remove effect of the left border
@isidorn isidorn added the verification-needed Verification of issue is requested label Feb 13, 2018
@isidorn isidorn closed this as completed Feb 13, 2018
@isidorn isidorn self-assigned this Feb 13, 2018
@bpasero
Copy link
Member

bpasero commented Feb 27, 2018 •
edited
Loading

Nope (Windows):
flicker_chrome58

@bpasero bpasero reopened this Feb 27, 2018
@bpasero bpasero added the verification-found Issue verification failed label Feb 27, 2018
@isidorn
Copy link
Contributor

isidorn commented Feb 27, 2018

Not important for this milestone
Fyi @ergun1017

@isidorn isidorn modified the milestones: February 2018, On Deck Feb 27, 2018
@bpasero bpasero removed verification-found Issue verification failed verification-needed Verification of issue is requested labels Feb 27, 2018
@isidorn isidorn removed their assignment Sep 21, 2018
@isidorn isidorn modified the milestones: On Deck, Backlog Sep 21, 2018
@TunedMidja TunedMidja mentioned this issue Oct 5, 2018
Closed
@garymathews garymathews mentioned this issue Oct 10, 2018
Merged
@isidorn isidorn self-assigned this Oct 15, 2018
@isidorn isidorn modified the milestones: Backlog, October 2018 Oct 15, 2018
@isidorn isidorn added the verification-needed Verification of issue is requested label Oct 15, 2018
@jrieken
Copy link
Member

jrieken commented Oct 30, 2018 •
edited
Loading

I now see this (using the GH Sharp theme)

screenshot 2018-10-30 at 10 53 08

@jrieken jrieken reopened this Oct 30, 2018
@isidorn isidorn modified the milestones: October 2018, Backlog Oct 31, 2018
@isidorn
Copy link
Contributor

isidorn commented Oct 31, 2018

Fixed the border by reverting the PR. The original issue still stands, moving it to the backlog

@octref octref removed the verification-needed Verification of issue is requested label Feb 25, 2019
@isidorn isidorn added the *out-of-scope Posted issue is not in scope of VS Code label Oct 8, 2019
@vscodebot
Copy link

vscodebot bot commented Oct 8, 2019

This issue is being closed to keep the number of issues in our inbox on a manageable level, we are closing issues that are not going to be addressed in the foreseeable future: We look at the number of votes the issue has received and the number of duplicate issues filed. More details here. If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding and happy coding!

@vscodebot vscodebot bot closed this as completed Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@isidorn isidorn

Labels
feature-request Request for new features or functionality file-explorer Explorer widget issues help wanted Issues identified as good community contribution opportunities *out-of-scope Posted issue is not in scope of VS Code ux User experience issues
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
6 participants
@bpasero @jrieken @isidorn @octref @mjbvz @wangweixuan