Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue #27393 - UX: align file names when renaming #60029

Closed
wants to merge 1 commit into from
Closed

Fix for issue #27393 - UX: align file names when renaming #60029

wants to merge 1 commit into from

Conversation

TunedMidja
Copy link

Fix for Issue #27393.

@FredrikOestlingPricer
Fixed CSS so that an explorer item text stays in the exact same place…
75e42b8 
… when going from viewing to editing mode and vice versa.
@isidorn
Copy link
Contributor

isidorn commented Oct 5, 2018

Did you verify this fix works?
On what OS did you verify?

@isidorn isidorn added this to the October 2018 milestone Oct 5, 2018
@TunedMidja
Copy link
Author

I've only verified it on OS X.

@isidorn
Copy link
Contributor

isidorn commented Oct 9, 2018 •
edited
Loading

@TunedMidja Thanks, I have just verified it is ok on OS X.
But not on Windows. Due to that I can not merge this PR. It might also not be good on Linux, I did not try.
Can you try to fix it also on Windows? Or should we wait for some other PR which does it on all platforms?

@isidorn isidorn modified the milestones: October 2018, Backlog Oct 9, 2018
@TunedMidja
Copy link
Author

This is not a specific fix for OS X but I haven't verified it on any other platform. Is there any easy way to do this (without setting up the entire development environment on Windows for example)?

@isidorn
Copy link
Contributor

isidorn commented Oct 10, 2018

I personally use Parallels. There is no simpler way afaik
I can merge in your PR, it helps on the mac, but I would keep the issue open since windows is still affected. Though I would prefer if we find a fix which works on all platforms

@TunedMidja
Copy link
Author

Why do you assume that it doesn't work on Windows? I looked at a rejected PR for fixing this issue:
#43443
Just by looking at the CSS class names (.monaco-workbench.linux and .monaco-workbench.mac) you can guess that this is not gonna work on Windows. But in my PR I changed another CSS class which has no hints of any OS so it should work for all platforms.
Of course it's better if it has been tested on all platforms but still.

@isidorn
Copy link
Contributor

isidorn commented Oct 10, 2018 •
edited
Loading

I did not assume. I actually tried it on Windows and it is not working. Sorry for not being more clear.

@TunedMidja
Copy link
Author

No problem. Thanks!

@isidorn
Copy link
Contributor

isidorn commented Oct 10, 2018

Args I made the stupid typo in my previous message. I typed now instead of not. Sorry.
It is not working on Win

@TunedMidja
Copy link
Author

OK, too bad. I might look into this further but I'm not sure as it would require setting up the entire dev environment on a Windows machine which would be very time consuming.

@garymathews garymathews mentioned this pull request Oct 10, 2018
Merged
@garymathews
Copy link
Contributor

@TunedMidja I had some time to look into this myself, this addresses all platforms #60539

@isidorn
Copy link
Contributor

isidorn commented Oct 11, 2018

@garymathews thanks a lot! Let me try out your PR on all platforms.
Closing this in in favor of the new PR

@isidorn isidorn closed this Oct 11, 2018
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@isidorn isidorn

Labels
None yet
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
4 participants
@TunedMidja @isidorn @garymathews @FredrikOestlingPricer