Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note: do not ignore Gradle wrapper files #1327

Merged
merged 2 commits into from
May 13, 2022

Conversation

v-jonathangu
Copy link
Contributor

@v-jonathangu v-jonathangu commented Jan 27, 2022

App Center Build Service does not find the project when you ignore the Gradle wrapper files, add a quick notice to not ignore those files on the docs, example:
ignore these files:
image
will show this on App Center Build:
image
if those files are ignored App Center Build might not find them, as some IDE generates them, like Android Studio the users may ignore them, for example Android Flutter projects (which aren't yet supported officially, see: microsoft/appcenter#67 ) ignore it by default, this PR adds a quick note that warns the user to not ignore them.

Quick Notes:

App Center Build Service does not find the project when you ignore the Gradle wrapper files, add a quick notice to not ignore those files on the docs
@PRMerger16 PRMerger16 added the do-not-merge Items are missing in PROD before docs are relevant label Jan 27, 2022
@PRMerger20
Copy link
Contributor

@v-jonathangu : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link

@stephan-markovic stephan-markovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to propose some changes to the text:
The App Center tracks the project by searching the gradle (and gradlew) directory files of the Android project. Please do not include these files in the project .gitignore as App Center Build will not be able to find them.

@lucen-ms lucen-ms assigned v-jonathangu and unassigned lucen-ms May 9, 2022
@PRMerger14
Copy link
Contributor

@v-jonathangu : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@lucen-ms
Copy link
Contributor

#sign-off

@PRMerger10 PRMerger10 removed the do-not-merge Items are missing in PROD before docs are relevant label May 13, 2022
@lucen-ms lucen-ms merged commit 165f608 into MicrosoftDocs:live May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants