Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snipped based setup discrepencies #54254

Closed
yohny opened this issue May 6, 2020 — with docs.microsoft.com · 6 comments
Closed

Snipped based setup discrepencies #54254

yohny opened this issue May 6, 2020 — with docs.microsoft.com · 6 comments

Comments

Copy link

yohny commented May 6, 2020

The snipped setup code sample on this doc page is different than the sample in app insight's readme.md on github (https://github.com/Microsoft/ApplicationInsights-js#snippet-setup-ignore-if-using-npm-setup)

Similar thing happened before, see #48152


Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

@yohny yohny changed the title Sipped based setup discrepencies Snipped based setup discrepencies May 6, 2020
@mrbullwinkle
Copy link
Contributor

@yohny thanks for reporting this, I will take care of this.

@mrbullwinkle
Copy link
Contributor

#assign:mrbullwinkle

@mrbullwinkle
Copy link
Contributor

Also just to answer your original question this is what was updated in the snippet: microsoft/ApplicationInsights-JS#1258. Pinging @MSNev to confirm that the snippet updates from the SDK repo readme should be added to any references to the snippet on docs.microsoft.com? (I can put the changes in now, but just wanted to confirm).

@MSNev
Copy link
Contributor

MSNev commented May 7, 2020 via email

@mrbullwinkle
Copy link
Contributor

This change was made live 11 days ago with this PR:
Update JS

@mrbullwinkle
Copy link
Contributor

#please-close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants