Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update storage-account-key-note-include.md to remove confusion in parent doc https://learn.microsoft.com/en-us/azure/storage/common/storage-account-keys-manage?tabs=azure-portal#protect-your-access-keys #123631

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

jolauMSFT
Copy link
Contributor

Correcting the permissions that storage account keys give you as tested with Storage Explorer v1.34. Accessing a Storage account with the key gives you full access to the data, but not to the configuration or other keys. This include is causing confusion and contradicts other parts of the parent Learn doc: https://learn.microsoft.com/en-us/azure/storage/common/storage-account-keys-manage?tabs=azure-portal#protect-your-access-keys.

Changing first sentence to read:
Storage account access keys provide full access to the storage account data, and the ability to generate SAS tokens. Always be careful to protect your access keys. Use Azure Key Vault to manage and rotate your keys securely. Access to the shared key grants a user full access to a storage account’s data.

Correcting the permissions that storage account keys give you as tested with Storage Explorer v1.34. Accessing a Storage account with the key gives you full access to the data, but not to the configuration or other keys. 
This include is causing confusion and contradicts other parts of the parent Learn doc: https://learn.microsoft.com/en-us/azure/storage/common/storage-account-keys-manage?tabs=azure-portal#protect-your-access-keys.
Copy link
Contributor

Learn Build status updates of commit f1f8e1d:

✅ Validation status: passed

File Status Preview URL Details
includes/storage-account-key-note-include.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@Jak-MS
Copy link
Contributor

Jak-MS commented Jul 5, 2024

@pauljewellmsft
Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Jul 5, 2024
Copy link
Contributor

@pauljewellmsft pauljewellmsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jolauMSFT Looks good - thanks!

@pauljewellmsft
Copy link
Contributor

#sign-off

Copy link
Contributor

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @

Copy link
Contributor

Learn Build status updates of commit ef11418:

✅ Validation status: passed

File Status Preview URL Details
includes/storage-account-key-note-include.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@Court72 Court72 merged commit f1f6563 into MicrosoftDocs:main Jul 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants