Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the TripPin.Feed type change more clear #522

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

brandonstubbs
Copy link

@brandonstubbs brandonstubbs commented Mar 20, 2024

I missed the step of updating the connector code to change the schema parameter and it took a while to figure out why all my unit tests were coming back as null except for the Check that we have three entries in our nav table test. It might be better to explicitly show this step. LMKWYT

@prmerger-automator prmerger-automator bot added the do-not-merge Don't merge this yet label Mar 20, 2024
Copy link
Contributor

@brandonstubbs : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit 8eccc7d:

✅ Validation status: passed

File Status Preview URL Details
powerquery-docs/samples/trippin/7-advancedschema/readme.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

@brandonstubbs : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@Court72
Copy link
Contributor

Court72 commented Mar 21, 2024

@DougKlopfenstein

Can you review the proposed changes?

When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@JasonWHowell JasonWHowell added the needs-engineering-review Discussing with Microsoft's engineering team. label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants