Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spacing of "-V" command #9842

Open
wants to merge 1 commit into
base: live
Choose a base branch
from

Conversation

emil-eklund
Copy link

Fixes spacing used in examples for the "-V" (severity) command.
Incorrect usage will cause the command to fail.

See earlier discussion: Azure/sql-action#235

Fixes spacing used in examples
Copy link
Contributor

@emil-eklund : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit 9a30ea2:

✅ Validation status: passed

File Status Preview URL Details
docs/tools/sqlcmd/sqlcmd-utility.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@emil-eklund
Copy link
Author

I think this passage is incorrect too, but I've not had the time to verify for all parameters:

Currently, sqlcmd doesn't require a space between the command-line option and the value. However, in a future release, a space may be required between the command-line option and the value.

@Court72
Copy link
Contributor

Court72 commented Jul 9, 2024

@dlevy-msft

Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Jul 9, 2024
@dlevy-msft
Copy link
Contributor

This appears to be an issue with the tool. Will need some time to investigate.

@emil-eklund
Copy link
Author

This appears to be an issue with the tool. Will need some time to investigate.

I agree. But I do also think the documentation should be updated if the following statement is true:

Currently, sqlcmd doesn't require a space between the command-line option and the value. However, in a future release, a space may be required between the command-line option and the value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants