Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PowerToys] Update and reorganize the PT Run page #3748

Merged
merged 17 commits into from
Mar 30, 2022
Merged

[PowerToys] Update and reorganize the PT Run page #3748

merged 17 commits into from
Mar 30, 2022

Conversation

htcfreek
Copy link
Contributor

This PR updates the PT Run docs page for the next release (v0.57.0), fixes some mistakes, corrects outdated information and reorganizes the page.

Linked issues:

Merge note

Don't merge this before the release of v0.57.0 and an approval of @crutkas or @jaimecbernardo!

@PRMerger20
Copy link
Contributor

@htcfreek : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@PRMerger6
Copy link
Contributor

@htcfreek : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@PRMerger4
Copy link
Contributor

@htcfreek : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@htcfreek htcfreek marked this pull request as ready for review March 27, 2022 16:41
@htcfreek
Copy link
Contributor Author

htcfreek commented Mar 27, 2022 •
edited
Loading

@mattwojo
Is there a way to see how this page looks in on the docs website after merging?

htcfreek
htcfreek commented Mar 27, 2022
View reviewed changes
hub/powertoys/run.md Outdated Show resolved Hide resolved
hub/powertoys/run.md Outdated Show resolved Hide resolved
hub/powertoys/run.md Outdated Show resolved Hide resolved
hub/powertoys/run.md Outdated Show resolved Hide resolved
hub/powertoys/run.md Outdated Show resolved Hide resolved
hub/powertoys/run.md Outdated Show resolved Hide resolved
hub/powertoys/run.md Outdated Show resolved Hide resolved
@htcfreek

This comment was marked as resolved.

Sign in to view
crutkas
crutkas reviewed Mar 27, 2022
View reviewed changes
hub/powertoys/run.md Outdated Show resolved Hide resolved
@PRMerger8
Copy link
Contributor

@htcfreek : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@htcfreek htcfreek requested a review from crutkas March 27, 2022 20:53
@PRMerger5
Copy link
Contributor

@htcfreek : Thanks for your contribution! The author(s) have been notified to review your proposed change.

htcfreek
htcfreek commented Mar 27, 2022
View reviewed changes
hub/powertoys/run.md Outdated Show resolved Hide resolved
@PRMerger14
Copy link
Contributor

@htcfreek : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@htcfreek
Copy link
Contributor Author

htcfreek commented Mar 27, 2022 •
edited
Loading

@crutkas
I updated the calculator table and added a warning about the comma separator bug in some calculator operations. PTAL.

I opened the issue microsoft/PowerToys#17300 for the comma bug.

@PRMerger15
Copy link
Contributor

@htcfreek : Thanks for your contribution! The author(s) have been notified to review your proposed change.

htcfreek
htcfreek commented Mar 28, 2022
View reviewed changes
hub/powertoys/run.md Outdated Show resolved Hide resolved
jaimecbernardo
jaimecbernardo suggested changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some nits.

hub/powertoys/run.md Outdated Show resolved Hide resolved
hub/powertoys/run.md Outdated Show resolved Hide resolved
hub/powertoys/run.md Show resolved Hide resolved
hub/powertoys/run.md Outdated Show resolved Hide resolved
hub/powertoys/run.md Outdated Show resolved Hide resolved
hub/powertoys/run.md Outdated Show resolved Hide resolved
hub/powertoys/run.md Outdated Show resolved Hide resolved
@jaimecbernardo
Copy link
Contributor

@crutkas , @jaimecbernardo What ifs the time frame for release/merge here?

In principle, the last commits for the release have already been decided and are already merged. We're testing release candidates right now.

@PRMerger13
Copy link
Contributor

@htcfreek : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@htcfreek
Copy link
Contributor Author

@jaimecbernardo , @crutkas
Nits are resolved. Should be good to go now.

jaimecbernardo
jaimecbernardo approved these changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@htcfreek
Copy link
Contributor Author

plz wait. there are missing plugins in the list. working on the commit

@PRMerger20
Copy link
Contributor

@htcfreek : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@PRMerger14
Copy link
Contributor

@htcfreek : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@htcfreek
Copy link
Contributor Author

@jaimecbernardo
Sorry. But I didn't saw that there were more plugins missing on the keyword table.

@PRMerger8
Copy link
Contributor

@htcfreek : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@PRMerger18
Copy link
Contributor

@htcfreek : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@PRMerger18
Copy link
Contributor

@htcfreek : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@PRMerger9
Copy link
Contributor

@htcfreek : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@htcfreek
Copy link
Contributor Author

@jaimecbernardo
System requirements updated.

@jaimecbernardo
Copy link
Contributor

Took a look at the recent changes. Still LGTM! Thanks @htcfreek !

@htcfreek
Copy link
Contributor Author

htcfreek commented Mar 30, 2022 •
edited
Loading

Who can merge this within the next time? New version of PT is released.

@mattwojo
Copy link
Contributor

@mattwojo Is there a way to see how this page looks in on the docs website after merging?

You would need to submit it to our private repo and have access to our internal-only review site.. so unfortunately no, unless I check it for you and share a screenshot... if there is ever anything with questionable formatting, happy to do so!

@mattwojo
Copy link
Contributor

These updates look great to me. I'll merge and then confirm formatting looks good once it builds live.

@mattwojo mattwojo merged commit c16c0b6 into MicrosoftDocs:docs Mar 30, 2022
@htcfreek
Copy link
Contributor Author

thank you for merging

@htcfreek htcfreek deleted the PtRun branch March 30, 2022 18:52
learn-build-service-prod bot pushed a commit that referenced this pull request Sep 1, 2023
@mattwojo
Add retention info for WinGet logs (#3748)
3df0415 
* Add retention info for WinGet logs

* Add preserve comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaimecbernardo jaimecbernardo jaimecbernardo approved these changes

@mattwojo mattwojo Awaiting requested review from mattwojo

@crutkas crutkas Awaiting requested review from crutkas

Assignees

@mattwojo mattwojo

Labels
aq-pr-triaged tracking label for the PR review team Change sent to author dev-environment/prod do-not-merge powertoys/tech PowerToys docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.