Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added new spec for a Non Client Area Hit Testing API #3278

Merged
merged 7 commits into from
Apr 6, 2023

Conversation

tochukwuIbeEkeocha
Copy link
Contributor

@tochukwuIbeEkeocha tochukwuIbeEkeocha commented Mar 7, 2023

This new API will provide the ability for visually hosted apps to do Hit-testing. It can support features related to mouse activity in regions that are traditionally Non-Client areas. Features like Draggable Regions,
Resize, Minimize/Maximize functionality, and more. This API is not meant to support environments that use a CoreWindow like UWP

specs/NCHitTestKind.md Outdated Show resolved Hide resolved
@tochukwuIbeEkeocha tochukwuIbeEkeocha force-pushed the api-NCHitTestPoint-draft branch 3 times, most recently from 91000f3 to 167c12d Compare March 8, 2023 18:35
specs/NCHitTestKind.md Outdated Show resolved Hide resolved
specs/NCHitTestKind.md Outdated Show resolved Hide resolved
specs/NCHitTestKind.md Outdated Show resolved Hide resolved
specs/NCHitTestKind.md Outdated Show resolved Hide resolved
specs/NCHitTestKind.md Outdated Show resolved Hide resolved
specs/NCHitTestKind.md Outdated Show resolved Hide resolved
specs/NCHitTestKind.md Outdated Show resolved Hide resolved
specs/NCHitTestKind.md Outdated Show resolved Hide resolved
specs/NCHitTestKind.md Outdated Show resolved Hide resolved
specs/NCHitTestKind.md Outdated Show resolved Hide resolved
@tochukwuIbeEkeocha tochukwuIbeEkeocha force-pushed the api-NCHitTestPoint-draft branch 5 times, most recently from ba832b1 to 92d88d1 Compare March 19, 2023 17:44
@tochukwuIbeEkeocha tochukwuIbeEkeocha force-pushed the api-NCHitTestPoint-draft branch from 92d88d1 to 1f4cbb8 Compare March 24, 2023 18:14
specs/NonClientHitTestKind.md Outdated Show resolved Hide resolved
specs/NonClientHitTestKind.md Outdated Show resolved Hide resolved
specs/NonClientHitTestKind.md Outdated Show resolved Hide resolved
specs/NonClientHitTestKind.md Outdated Show resolved Hide resolved
specs/NonClientHitTestKind.md Outdated Show resolved Hide resolved
specs/NonClientHitTestKind.md Outdated Show resolved Hide resolved
specs/NonClientHitTestKind.md Outdated Show resolved Hide resolved
specs/NonClientHitTestKind.md Outdated Show resolved Hide resolved
specs/NonClientHitTestKind.md Outdated Show resolved Hide resolved
specs/NonClientHitTestKind.md Outdated Show resolved Hide resolved
@tochukwuIbeEkeocha tochukwuIbeEkeocha force-pushed the api-NCHitTestPoint-draft branch 2 times, most recently from 651cd43 to 80cf32d Compare March 24, 2023 22:28
specs/NonClientHitTestKind.md Outdated Show resolved Hide resolved
specs/NonClientHitTestKind.md Outdated Show resolved Hide resolved
specs/NonClientHitTestKind.md Outdated Show resolved Hide resolved
specs/NonClientHitTestKind.md Outdated Show resolved Hide resolved
specs/NonClientHitTestKind.md Outdated Show resolved Hide resolved
specs/NonClientHitTestKind.md Outdated Show resolved Hide resolved
@tochukwuIbeEkeocha tochukwuIbeEkeocha force-pushed the api-NCHitTestPoint-draft branch from 80cf32d to 99efda6 Compare March 27, 2023 23:43
Copy link
Contributor

@david-risney david-risney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Some more minor feedback about the ref documentation. If Brad is good on the sample code and otherwise, then should be good after the most recent feedback. Thanks

specs/NonClientHitTestKind.md Outdated Show resolved Hide resolved
specs/NonClientHitTestKind.md Outdated Show resolved Hide resolved
specs/NonClientHitTestKind.md Outdated Show resolved Hide resolved
specs/NonClientHitTestKind.md Outdated Show resolved Hide resolved
specs/NonClientHitTestKind.md Outdated Show resolved Hide resolved
specs/NonClientHitTestKind.md Outdated Show resolved Hide resolved
specs/NonClientHitTestKind.md Outdated Show resolved Hide resolved
specs/NonClientHitTestKind.md Outdated Show resolved Hide resolved
specs/NonClientHitTestKind.md Outdated Show resolved Hide resolved
tochukwuIbeEkeocha and others added 5 commits March 30, 2023 15:18
Co-authored-by: David Risney <dave@deletethis.net>
Co-authored-by: David Risney <dave@deletethis.net>
Co-authored-by: David Risney <dave@deletethis.net>
Co-authored-by: David Risney <dave@deletethis.net>
@tochukwuIbeEkeocha tochukwuIbeEkeocha force-pushed the api-NCHitTestPoint-draft branch from 4beface to b76a803 Compare April 3, 2023 16:47
specs/NonClientHitTestKind.md Show resolved Hide resolved
specs/NonClientHitTestKind.md Outdated Show resolved Hide resolved
specs/NonClientHitTestKind.md Outdated Show resolved Hide resolved
specs/NonClientHitTestKind.md Outdated Show resolved Hide resolved
specs/NonClientHitTestKind.md Outdated Show resolved Hide resolved
specs/NonClientHitTestKind.md Outdated Show resolved Hide resolved
specs/NonClientHitTestKind.md Outdated Show resolved Hide resolved
@tochukwuIbeEkeocha tochukwuIbeEkeocha force-pushed the api-NCHitTestPoint-draft branch 5 times, most recently from 019fa4a to 46f39ce Compare April 5, 2023 23:25
specs/NonClientHitTestKind.md Outdated Show resolved Hide resolved
specs/NonClientHitTestKind.md Outdated Show resolved Hide resolved
specs/NonClientHitTestKind.md Show resolved Hide resolved
specs/NonClientHitTestKind.md Outdated Show resolved Hide resolved
@tochukwuIbeEkeocha tochukwuIbeEkeocha force-pushed the api-NCHitTestPoint-draft branch from 46f39ce to f78a8b8 Compare April 6, 2023 18:11
Copy link
Contributor

@david-risney david-risney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the two issues, then complete your PR, then open a new PR to main, let me know, and I will schedule an API review. Thanks!

specs/NonClientHitTestKind.md Outdated Show resolved Hide resolved
specs/NonClientHitTestKind.md Show resolved Hide resolved
@tochukwuIbeEkeocha tochukwuIbeEkeocha force-pushed the api-NCHitTestPoint-draft branch from f78a8b8 to da5acfc Compare April 6, 2023 20:45
@tochukwuIbeEkeocha tochukwuIbeEkeocha merged commit 14d50ef into api-NCHitTestPoint Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Proposal Review WebView2 API Proposal for review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants